Skip to content

Pls merge#19

Open
Twig6943 wants to merge 12 commits intoevg-zhabotinsky:masterfrom
Twig6943:master
Open

Pls merge#19
Twig6943 wants to merge 12 commits intoevg-zhabotinsky:masterfrom
Twig6943:master

Conversation

@Twig6943
Copy link
Copy Markdown

@Twig6943 Twig6943 commented Jun 7, 2025

  • Adds -lm Add math lib to extra libs #14
  • Makes it use .config for files (this is required for it to work without root in some cases)
  • Adds placeholder CONTRIBUTING & actions files

@normalUserKarn
Copy link
Copy Markdown

this is a necropost or something, but
rm -f ~/.config/speedhack/speedhack_{pipe,log}
should probably be replaced with
rm -f ~/.config/{speedhack_pipe,speedhack/speedhack_log}
to function as intended

@evg-zhabotinsky
Copy link
Copy Markdown
Owner

Sorry for the wait, this PR slipped my attention.

  • What is -lm for? I distinctly remember getting rid of the flag to avoid a potential extra dependency for portable builds. The current "release" binaries only depends on libc.
  • Moving from /tmp to ~ is indeed a good idea for multi-user systems, in case there are stale files from other users, but I think ~/.cache/libspeedhack/ would be a better location, it is the closest per-user equivalent to /tmp.

@Twig6943
Copy link
Copy Markdown
Author

Twig6943 commented Jul 8, 2025

just nvm this pr (this thing is kinda useless since it needs to be rewritten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants