Open
Conversation
Create game ini if path is valid but file missing. Add game ini options if missing.
Change copied game ini instead of one selected in host.yaml Also changed "PINESlot" to "pineslot".
Capitalized game ini settings: [EmuCore] EnablePINE = true PINESlot = 28011 [Achievements] Enabled = false
Make sure game settings ini works with or without capitalization.
Keep original ini untouched.
Added /start command to launch .aprac2 Included checks to make sure host.yaml has propper settings.
Now verify iso copy when creating vanilla iso in archipelago directory. Should hopefully fix problems some users have. Could still happen if people close mid copy or ignore errors. But client should warn against that.
Logging doesn't work. Main issue is probably people closing the client anyway. Could put a message in to tell people to not close the client. But already get an error when trying to open the patch message after copying iso.
Author
|
Also found out that patches actually store room data, and update with the room. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a way for having dynamic PINE port set for each instance of the client/PCSX2
Allowing you to run multiple instances at the same time & play without issues.
Currently it adds a
/startcommand to manually launch from within the client.There's some checks and non-halting errors for if you're missing
host.yamlsettingsWould like to improve it more, but honestly my knowledge of AP coding is quite limited so here's what i have so far.
Myself, and a few other people have tested it fine without issue.
Only problems we've noticed if you start instances too quickly PINE can become desynced.
If you don't have an iso set and run
/startit will give an error, and not prompt for.aprac2. Running command again works tho.Also tried warning the user to not close client while moving iso. But couldn't get it working smoothly so has been removed.
Let me know if any changes are needed. Currently include a lot of comments for sections i've changed.
Gonna include what i had in my release notes here:
Release notes
Testing Dynamic PINE ports for multi PCSX2 instance support.
Based on: https://github.com/evilwb/APRac2/releases/tag/v0.6.4
Setup
You need every RaC2 option in your
host.yamlsetup. That means:iso_fileto a valid vanilla iso in your Archipelago directory (should be already from normal setup)iso_startto your PCSX2 exe (Make sure to use/)game_inito a game settings file in your PCSX2's gamesettings folder.(Usually
%USERPROFILE%/Documents/PCSX2/gamesettings/SCUS-97268_38996035.ini)Example:
Game settings ini example:
Recommended you use your settings for vanilla RaC2. But you can make a copy with specific edits.
So you can set an AP specific memory card like in the example above. (You don't need to add PINE settings)
For normal setup if you haven't already. Check GitHub, and Discord.
Start
Simply run a
.aprac2file with Archipelago. (Recommended to set to open.aprac2files with Archipelago by default)Or run the client, and use the
/startcommand, and then select your desired.aprac2file.Note: You can rename
aprac2and patchedisobut they have to have the same name or it'll make anotheriso.(Same way you have to keep
.apsave, and their.zipname the same if hosting locally)Full changes: jacobmix/APRac2@main...v0.6.5-PINE-pre