Merged
Conversation
Dinopony
approved these changes
Mar 23, 2025
Collaborator
Dinopony
left a comment
There was a problem hiding this comment.
That's some incredible QoL at almost no cost, good job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STARTon loaded savesThrough some searching, I found the variable that controls cutscene skip-ability. It is a global at address
0x001A7478that I'm callingeasy_cutscene_skip. It behaves different on title screen vs on planets. On planets, it's quite straight forward. 0 means you must holdL1+R1+L2+R2+STARTto skip and 1 means you just need to pressSTART. For title screen, early boot sets this value to 3. If it is 3, the opening cinematic can't be skipped. If it is anything else, the opening cinematic can be skipped.All I do is NOP the instruction that sets
easy_cutscene_skipto 3 on boot and have the client set it to 1 oninitcallback.