-
Notifications
You must be signed in to change notification settings - Fork 33
Add type hints to function signatures and fix linting errors #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jrom99
wants to merge
20
commits into
evogytis:master
Choose a base branch
from
jrom99:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,587
−1,646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've added the type hints to function signatures, and removed the
setup.pyfile in favor ofpyproject.toml. I then fixed all linting errors that were raised bybasedpyrightbasic type checking mode.One of the tests was not passing because the regex was case sensitive, so I also updated the regex.
I've made some QOL improvements so that
plotTreecan now autoscale to its contents and use strings forx_attrandy_attr. AndrenameTipscan reuse the old names when they are missing (so you can rename specified tips and reticulations).The
decimalDatefunction seemed to assume multiple things about the input data format (single char separator, same separator for all items, dates are stored left-to-right), so I added support for extracting and using each separator from the format string.I used f-strings instead of the older
formatmethod, and r-escaped some of the regex to remove the warnings.Overall, there were no backward-incompatible changes to the API itself, but the type annotations require python >= 3.9 (was 3.8 before).