Open
Conversation
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
from
664d1cd to
8ef6bad
Compare
szenzaro
requested changes
May 3, 2021
src/app/components/annotator/text-annotator/text-annotator.component.html
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
giuliac89
requested changes
May 3, 2021
Member
giuliac89
left a comment
giuliac89
left a comment
There was a problem hiding this comment.
Improves the layout. Maybe I would remove the labels and leave only the icons (changing the annotation icon in to a more explanatory one). Do you have a layout in mind?
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
2 times, most recently
from
3a77f4a to
392a112
Compare
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
2 times, most recently
from
2cc48ae to
1bc4dad
Compare
szenzaro
requested changes
Jun 10, 2021
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
|
|
||
| openCreation(choice){ | ||
| this.annoType = choice; | ||
| this.showAdder = choice !== 'annotate' ? true : false; |
Contributor
There was a problem hiding this comment.
no need of ternary operator: choice !== 'annotate' is enough
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
3 times, most recently
from
cb422f9 to
b56752d
Compare
szenzaro
requested changes
Jun 12, 2021
src/app/components/annotator/text-annotator/text-annotator.component.ts
Outdated
Show resolved
Hide resolved
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
3 times, most recently
from
b59469c to
52a3f21
Compare
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
2 times, most recently
from
43239e8 to
6d61dd1
Compare
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
2 times, most recently
from
05d0fae to
ddd7149
Compare
giacomocerre
force-pushed
the
feature/text-annotator-menu
branch
from
ddd7149 to
92ff3cb
Compare
giuliac89
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.