Open
Conversation
|
@ewlsh could you please QA and merge the PR? |
Author
|
I've tried to contact him on his mail address, didn't respond. I'm thinking about creating a proper fork, but there are alternatives I need to test first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there and thanks for this great extension !
I reeeaally wanted it to work in gnome 45, so I had a look at the code. Turns out very few changes were needed. I'm not sure I had to rewrite the preferences window but couldn't find a way to plug your code.
Sometimes, there are some minor weird behavior in the preferences, I'm not sure it's my fault or if it was like that already. I'll keep digging but it's totally usable in the meantime !
Hope it will be good enough :)