Skip to content

add zfa support #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add zfa support #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/common/restore-stage-2/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ runs:
touch -d "+2 days" build-glibc-linux-rv32imac-ilp32
touch -d "+2 days" build-glibc-linux-rv32imafdc-ilp32d
touch -d "+2 days" build-glibc-linux-rv32gcv-ilp32d
touch -d "+2 days" build-glibc-linux-rv32gc_zba_zbb_zbc_zbs-ilp32d
touch -d "+2 days" build-glibc-linux-rv32gc_zba_zbb_zbc_zbs_zfa-ilp32d
touch -d "+2 days" build-glibc-linux-rv32gcv_zvbb_zvbc_zvkg_zvkn_zvknc_zvkned_zvkng_zvknha_zvknhb_zvks_zvksc_zvksed_zvksg_zvksh_zvkt-ilp32d
touch -d "+2 days" build-glibc-linux-rv64gc-lp64d
touch -d "+2 days" build-glibc-linux-rv64imac-lp64
touch -d "+2 days" build-glibc-linux-rv64imafdc-lp64d
touch -d "+2 days" build-glibc-linux-rv64gcv-lp64d
touch -d "+2 days" build-glibc-linux-rv64gc_zba_zbb_zbc_zbs-lp64d
touch -d "+2 days" build-glibc-linux-rv64gc_zba_zbb_zbc_zbs_zfa-lp64d
touch -d "+2 days" build-glibc-linux-rv64gcv_zvbb_zvbc_zvkg_zvkn_zvknc_zvkned_zvkng_zvknha_zvknhb_zvks_zvksc_zvksed_zvksg_zvksh_zvkt-lp64d
touch -d "+2 days" build-glibc-linux-rv64imafdcv_zicond_zawrs_zbc_zvkng_zvksg_zvbb_zvbc_zicsr_zba_zbb_zbs_zicbom_zicbop_zicboz_zfhmin_zkt-lp64d
touch -d "+2 days" build-newlib-nano
Expand Down
8 changes: 4 additions & 4 deletions .github/actions/download-all-comparison-artifacts/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ runs:
- name: Download linux rv32 bitmanip non-multilib
uses: ./.github/actions/common/download-comparison-artifacts
with:
report-artifact-name: gcc-linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-${{ inputs.gcchash }}-non-multilib-report.log
binary-artifact-name: gcc-linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-${{ inputs.gcchash }}-non-multilib
report-artifact-name: gcc-linux-rv32gc_zba_zbb_zbc_zbs_zfa-ilp32d-${{ inputs.gcchash }}-non-multilib-report.log
binary-artifact-name: gcc-linux-rv32gc_zba_zbb_zbc_zbs_zfa-ilp32d-${{ inputs.gcchash }}-non-multilib
github-token: ${{ inputs.token }}
repo: ${{ inputs.repo }}

- name: Download linux rv64 bitmanip non-multilib
uses: ./.github/actions/common/download-comparison-artifacts
with:
report-artifact-name: gcc-linux-rv64gc_zba_zbb_zbc_zbs-lp64d-${{ inputs.gcchash }}-non-multilib-report.log
binary-artifact-name: gcc-linux-rv64gc_zba_zbb_zbc_zbs-lp64d-${{ inputs.gcchash }}-non-multilib
report-artifact-name: gcc-linux-rv64gc_zba_zbb_zbc_zbs_zfa-lp64d-${{ inputs.gcchash }}-non-multilib-report.log
binary-artifact-name: gcc-linux-rv64gc_zba_zbb_zbc_zbs_zfa-lp64d-${{ inputs.gcchash }}-non-multilib
github-token: ${{ inputs.token }}
repo: ${{ inputs.repo }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-target.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ jobs:
[
# rv32gcv-ilp32d, # rv32 vector
# rv64gcv-lp64d, # rv64 vector
rv32gc_zba_zbb_zbc_zbs-ilp32d, # rv32 bitmanip
rv64gc_zba_zbb_zbc_zbs-lp64d, # rv64 bitmanip
rv32gc_zba_zbb_zbc_zbs_zfa-ilp32d, # rv32 bitmanip
rv64gc_zba_zbb_zbc_zbs_zfa-lp64d, # rv64 bitmanip
# rv32gcv_zvbb_zvbc_zvkg_zvkn_zvknc_zvkned_zvkng_zvknha_zvknhb_zvks_zvksc_zvksed_zvksg_zvksh_zvkt-ilp32d, # rv32 vector crypto
# rv64gcv_zvbb_zvbc_zvkg_zvkn_zvknc_zvkned_zvkng_zvknha_zvknhb_zvks_zvksc_zvksed_zvksg_zvksh_zvkt-lp64d, # rv64 vector crypto
# rv64imafdcv_zicond_zawrs_zbc_zvkng_zvksg_zvbb_zvbc_zicsr_zba_zbb_zbs_zicbom_zicbop_zicboz_zfhmin_zkt-lp64d, # RVA23U64 profile with optional extensions, excluding unsupported extensions
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/generate-precommit-summary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ jobs:
run: |
# Download linux
python ./scripts/download_artifact.py -name gcc-linux-rv64gcv-lp64d-${{ inputs.baseline_hash }}-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
python ./scripts/download_artifact.py -name gcc-linux-rv64gc_zba_zbb_zbc_zbs-lp64d-${{ inputs.baseline_hash }}-non-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
python ./scripts/download_artifact.py -name gcc-linux-rv32gc_zba_zbb_zbc_zbs-ilp32d-${{ inputs.baseline_hash }}-non-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
python ./scripts/download_artifact.py -name gcc-linux-rv64gc_zba_zbb_zbc_zbs_zfa-lp64d-${{ inputs.baseline_hash }}-non-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
python ./scripts/download_artifact.py -name gcc-linux-rv32gc_zba_zbb_zbc_zbs_zfa-ilp32d-${{ inputs.baseline_hash }}-non-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
# Download newlib
python ./scripts/download_artifact.py -name gcc-newlib-rv64gcv-lp64d-${{ inputs.baseline_hash }}-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
python ./scripts/download_artifact.py -name gcc-newlib-rv64gc-lp64d-${{ inputs.baseline_hash }}-non-multilib-sum-files -repo patrick-rivos/gcc-postcommit-ci -token ${{ secrets.GITHUB_TOKEN }} -outdir ./temp
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
printf "## Target Information\n" >> issue.md
printf "|Target Shorthand|\`-march\` string|\n" >> issue.md
printf "|-|-|\n" >> issue.md
printf "|Bitmanip|\`gc_zba_zbb_zbc_zbs\`|\n" >> issue.md
printf "|Bitmanip|\`gc_zba_zbb_zbc_zbs_zfa\`|\n" >> issue.md
printf "## Notes\n" >> issue.md
echo "Testsuite results use a more lenient allowlist to reduce error reporting with flakey tests. Please take a look at the current [allowlist](https://github.com/ewlu/gcc-precommit-ci/tree/main/test/allowlist)." >> issue.md
echo "Results come from a [sum file comparator](https://github.com/patrick-rivos/riscv-gnu-toolchain/blob/a0a8cabf8ca71bdfbb41e23ab599af9528af772c/scripts/compare_testsuite_log.py). Each patch is applied to a well known, non-broken baseline taken from our" >> issue.md
Expand Down
2 changes: 1 addition & 1 deletion riscv-gnu-toolchain
Open in desktop
Submodule riscv-gnu-toolchain updated 3 files
+1 −0 scripts/aggregate.py
+11 −0 test/allowlist/gcc/glibc.log
+4 −0 test/allowlist/gcc/glibc.rv32.zbs.log