Skip to content

update total targets in resolved/new failures reporting #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: patchworks-ci
Choose a base branch
from
Open

update total targets in resolved/new failures reporting #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions scripts/aggregate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ def get_unique_failures(failure_type: str, intersect: Set[str], failures: Dict[s
result += "```\n"
return result

def additional_failures_to_markdown(failure_type: str, failures: Dict[str, Set[str]]):
def additional_failures_to_markdown(failure_type: str, failures: Dict[str, Set[str]], num_targets: int):
"""
Adds new sections to issue displaying what failures were added/resolved
"""
intersect, num_failures = get_common_intersection(failures)
result = ""
if len(intersect) > 0:
found_failures = sorted(list(intersect))
result = f"## {failure_type} Failures Across All Affected Targets ({num_failures} targets / {len(failures)} total targets)\n"
result = f"## {failure_type} Failures Across All Affected Targets ({num_failures} targets / {num_targets} total targets)\n"
result += "```\n"
result += "".join(found_failures)
result += "```\n"
Expand Down Expand Up @@ -246,9 +246,13 @@ def main():
all_resolved[file] = resolved
all_new[file] = new


print(all_resolved)
print(all_new)
print(failures)
summary_markdown = failures_to_markdown(failures, args.current_hash, args.patch_name)
resolved_markdown = additional_failures_to_markdown("Resolved", all_resolved)
new_markdown = additional_failures_to_markdown("New", all_new)
resolved_markdown = additional_failures_to_markdown("Resolved", all_resolved, len(failures['Unresolved']))
new_markdown = additional_failures_to_markdown("New", all_new, len(failures['Unresolved']))

markdown = summary_markdown + new_markdown + resolved_markdown

Expand Down