Conversation
ewowi
reviewed
Jun 14, 2024
|
|
||
| if(!lds->newFrame) return; | ||
|
|
||
| int bri = mdl->getValue("bri"); |
Owner
There was a problem hiding this comment.
mdl->getValue is too expensive to call in loop()
recently added variables by reference, so added bri as a referenced variable here:
Check e3b85de
so fix->bri can be used here as well
ewowi
reviewed
Jun 14, 2024
| ${STARMOD_USERMOD_E131.lib_deps} | ||
| ; ${STARMOD_USERMOD_HA.lib_deps} | ||
| ${STARMOD_USERMOD_WLEDAUDIO.lib_deps} | ||
| ${usermod_hub75.lib_deps} |
Owner
There was a problem hiding this comment.
default builds disabled / commented ?
|
Is this testable? Did not compile for me. |
ewoudwijma
added a commit
that referenced
this pull request
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.