[image_spec]: Fail when image existence check fails #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When
ImageSpec.exist()returnsNone(failed to verify if image exists due to Docker not running, AWS CLI issues, network problems, etc.), the previous behavior was to assume the image exists and skip building. This causedErrImagePullerrors at runtime when the image didn't actually exist in the registry.Example error that triggered this fix:
What changes were proposed in this pull request?
Changed the behavior in
ImageSpecBuilder.should_build()whenexist()returnsNone:RuntimeErrorwith a clear message explaining how to fix the issueThis fails fast and surfaces the real problem (Docker/AWS not configured) immediately, rather than failing later at pod scheduling time with a confusing
ErrImagePullerror.How was this patch tested?
Manual verification of the logic change. The fix is minimal and the behavior is straightforward.
Human review checklist
FLYTE_FORCE_PUSH_IMAGE_SPEC=1to force rebuildCheck all the applicable boxes
Link to Devin run: https://app.devin.ai/sessions/2d0f2b4119614e8db4c39e002b676ce8
Requested by: @j93hahn