Update URLs in exercise READMEs for nexercism [closes #205]#218
Open
jeremy-w wants to merge 3 commits intoexercism:mainfrom
Open
Update URLs in exercise READMEs for nexercism [closes #205]#218jeremy-w wants to merge 3 commits intoexercism:mainfrom
jeremy-w wants to merge 3 commits intoexercism:mainfrom
Conversation
Cribbed liberally from the C++ version: https://github.com/exercism/cpp/blob/32d08a0822d5d14c10ccc4484c69afed1130f795/config/exercise_readme.go.tmpl Also added the latest bits from the template readme prolog: https://github.com/exercism/docs/blob/737cd278c85cbf5a1581c1bb115729f5857e22de/language-tracks/exercises/anatomy/readmes.md#default-template We can't adopt the track hints README insert, because we rely on interpolation of details of the specific exercise, and the config/exercise-readme-insert.md is injected literally, without access to any formatting variables.
Configlet emitted one error. It has to do with this being track-specific exercise, not one of the shared ones, it seems? ``` -> 1 error occurred: * open ../problem-specifications/exercises/bracket-push/metadata.yml: no such file or directory ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configlet doesn't like bracket-push. Luckily it griped aloud, so I knew to look closer. I had to manually update the README for that exercise.
I'm not clueful enough about the Exercism wiring to know how to fix that, but I hope there's some way to get track-specific exercises to play nice with configlet.
Note to Reviewer
You'll want to review by commit. The middle commit touching ALL the files is entirely machine-generated. The other two left room for human error.