Merged
Conversation
…events + missing pickup and equip sounds
Yentis
force-pushed
the
feature/config-persistence
branch
from
f40bdff to
8f8de49
Compare
Owner
|
Would it be better to use directories::ProjectDirs.data_local_dir like the server does? https://github.com/exjam/rose-offline/blob/main/rose-offline-server/src/game/storage/mod.rs |
…s/rose-offline-client into feature/config-persistence
Contributor
Author
|
Sure, should it be in rose-offline or a new rose-offline-client? |
Owner
|
Yeah lets put it in rose-offline-client i suppose to keep it seperate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started from #14
It uses ./config.toml as the default if no path is provided.
Save of config happens upon changing any settings in the settings menu.
Maybe (some of) the settings should be saved to / read from SevenHearts.ini?