Skip to content

Fix additional damage attribute reducing damage#55

Merged
exjam merged 2 commits intoexjam:mainfrom
Yentis:feature/additional-damage-fix
Mar 25, 2026
Merged

Fix additional damage attribute reducing damage#55
exjam merged 2 commits intoexjam:mainfrom
Yentis:feature/additional-damage-fix

Conversation

@Yentis
Copy link
Copy Markdown
Contributor

@Yentis Yentis commented Mar 23, 2026

No description provided.

@exjam
Copy link
Copy Markdown
Owner

exjam commented Mar 25, 2026

If we want to keep this as close as possible to the original official source CCal functions

		if ( FLAG_ING_DUMMY_DAMAGE & pATK->GetIngDurationStateFLAG() ) {
			iDamage += (int)( iDamage * SKILL_POWER( pATK->GetIngDurationStateSKILL( ING_DUMMY_DAMAGE ) ) / 100.f );
			// iDamage |= DMG_BIT_DUMMY;
		}

It seems what we should have done is:
damage += damage * attacker.get_additional_damage_multipler();

@exjam exjam merged commit 4a648ba into exjam:main Mar 25, 2026
3 checks passed
@exjam
Copy link
Copy Markdown
Owner

exjam commented Mar 25, 2026

Thanks!

@Yentis Yentis deleted the feature/additional-damage-fix branch March 25, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants