This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Fix/1.2.x/soc 2485#41
Open
quangpld wants to merge 1 commit intoexoplatform:stable/1.2.xfrom
exodev:fix/1.2.x/SOC-2485
Open
Fix/1.2.x/soc 2485#41quangpld wants to merge 1 commit intoexoplatform:stable/1.2.xfrom exodev:fix/1.2.x/SOC-2485
quangpld wants to merge 1 commit intoexoplatform:stable/1.2.xfrom
exodev:fix/1.2.x/SOC-2485
Conversation
… on the Activity stream gadget
rdenarie
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Binding_reports: Add sql table, entity and dao for the binding reports. * Create GroupSpaceBindingReports : ** Add GroupSpaceBindingReport object ** Add the possibility to create/delete GroupSpaceBindingReportEntity ** Add the possibility to search GroupSpaceBindingReport from (space, groupspacebinding, group, action ** Start the create the function to get the CSV file * create the export to csv file * Make cleanup : remove duplicate code * Add report binding for add action, remove action, and for update action * change relation between space and groupBindingReport, to have delete on cascade * Binding Report - add field stillInSpace * use field stillPresent in binding reports csv * Update test for testing reports and new field stillInSpace * Binding_reports: Make Binding reports table fields internationalized. * FixSocialBuild: Fix rest service test. (#34) * Problem when deleting a binding ** When a group is bound to 2 spaces, and when you delete one of theses binding, the users are removed from both spaces ** This fix changes the way we get userBinding, to get only userBinding linked to this group binding, and not link to the group name * fix comment * Fix binding process of remove user membership synchronization. * Add GroupSpaceBindingOperationReport model and rest entity. * Add method getGroupSpaceBindingReportOperations. * Add GroupSpaceBindingOperationReport model and rest entity. * Implement rest service for retrieving binding reports. * Fix method getGroupSpaceBindingReportOperations. * Fix rest service. * Add sql table for GroupSpaceBindingReportUser. * Add GroupSpaceBindingReportUserDAO. * Add GroupSpaceBindingReportUser model. * Fix the case when a userBinding is removed ** If the userBinding is removed due to groupBinding remove, ** the user should stay in space if he has other binding or if he was member before ** If the userBinding is remove because user leaves the group, ** then the user should stay in space only if he has other binding * Rename GroupSpaceBindingReportDAO. * Add the process of saving binding reports. * Add binding Process of retrieving binding reports operations. * Fix GroupSpaceBindingServiceTest. * change the function getReportsForCSV to use only one action * comment code to make it build. I will rework on it after. * Change object for GroupBindingReport * fix problem in changelog, and update ReportAction and ReportUsers to use object instead of id * update TU * Fix method buildEntityGroupSpaceBindingReportUserFrom. * add unit tests * Fix retrieving process of operationsReprot. * Fix methods updateGroupSpaceBindingReportAction and buildEntityFromGroupSpaceBindingOperationReport. * Fix GroupSpaceBindingOperationReportEntity. * Add space Etnity to the report entity. * Add methods getAllFromBindingQueue. * Complete test set * Make sure to add binding reports from the binding queue and fix ExoSpacesAdministrationBindingReports. * update the findReportForCSV function * Fix method getBindingReportOperations in rest service. * create report when the binding is created * save the synchronize report correctly * Fix display of binding reports table. * make savBinding and saveReport correct * Fix display of end date. * Fix Display of table headers. * Fix display of reports table columns. * format date * display group label & fix date display * Add button for upload file. * Add function uploadCSVFile. * update report link * Fix operation type names. * simplify the getBindingReports * Fix display of reports table and make sure the filter is working and code cleanup. * Make sure the search works on space name. * make SpaceBindingReport display sync when create or remove a binding * Take care of delete groups * use correct action name for export file * update startDate and endDate column name * fix remove binding when user is deleted * make filter working * Make sure when applying binding changes to redirect to the binding reports after the erquest is fulfilled. (#40) * when deleting a groupBinding, we want the ReportAction create directly, not when the job starts * Fix-BindingReport-US11/13 : Fix search and filter in table binding reports. (#41) ** Fix binding reports table filter and search. ** Fix method buildEntityFromGroup. * when 'New Binding' label to 'Add Binding' * fix problem when a userbinding already exists, we should not duplicate it. * Fix-BinindgReport-US04: Make sure to display directly the report of synchronize when a boun group is removed. (#42) * fix reports when user leave the group and action is syncrhonize * Fix-BindingReports-UI: Update label Synchronization to Synchronize. (#43) * Fix-BindingReports-UI-01: Fix display of binding reports table. (#47) ** Fix display of reports table filter and search field. ** Fix reports table filter. ** Fix display of reports filter. * BindingReports_US04 : in report tab, do not count user still in space for remove lines * Fix-BindingReports-UI-02: Fix reports table filter. (#48) * Fix-BindingReports-UI-03: Fix alignment of space name and avatar in reports table. (#49)
rdenarie
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Binding_reports: Add sql table, entity and dao for the binding reports. * Create GroupSpaceBindingReports : ** Add GroupSpaceBindingReport object ** Add the possibility to create/delete GroupSpaceBindingReportEntity ** Add the possibility to search GroupSpaceBindingReport from (space, groupspacebinding, group, action ** Start the create the function to get the CSV file * create the export to csv file * Make cleanup : remove duplicate code * Add report binding for add action, remove action, and for update action * change relation between space and groupBindingReport, to have delete on cascade * Binding Report - add field stillInSpace * use field stillPresent in binding reports csv * Update test for testing reports and new field stillInSpace * Binding_reports: Make Binding reports table fields internationalized. * FixSocialBuild: Fix rest service test. (#34) * Problem when deleting a binding ** When a group is bound to 2 spaces, and when you delete one of theses binding, the users are removed from both spaces ** This fix changes the way we get userBinding, to get only userBinding linked to this group binding, and not link to the group name * fix comment * Fix binding process of remove user membership synchronization. * Add GroupSpaceBindingOperationReport model and rest entity. * Add method getGroupSpaceBindingReportOperations. * Add GroupSpaceBindingOperationReport model and rest entity. * Implement rest service for retrieving binding reports. * Fix method getGroupSpaceBindingReportOperations. * Fix rest service. * Add sql table for GroupSpaceBindingReportUser. * Add GroupSpaceBindingReportUserDAO. * Add GroupSpaceBindingReportUser model. * Fix the case when a userBinding is removed ** If the userBinding is removed due to groupBinding remove, ** the user should stay in space if he has other binding or if he was member before ** If the userBinding is remove because user leaves the group, ** then the user should stay in space only if he has other binding * Rename GroupSpaceBindingReportDAO. * Add the process of saving binding reports. * Add binding Process of retrieving binding reports operations. * Fix GroupSpaceBindingServiceTest. * change the function getReportsForCSV to use only one action * comment code to make it build. I will rework on it after. * Change object for GroupBindingReport * fix problem in changelog, and update ReportAction and ReportUsers to use object instead of id * update TU * Fix method buildEntityGroupSpaceBindingReportUserFrom. * add unit tests * Fix retrieving process of operationsReprot. * Fix methods updateGroupSpaceBindingReportAction and buildEntityFromGroupSpaceBindingOperationReport. * Fix GroupSpaceBindingOperationReportEntity. * Add space Etnity to the report entity. * Add methods getAllFromBindingQueue. * Complete test set * Make sure to add binding reports from the binding queue and fix ExoSpacesAdministrationBindingReports. * update the findReportForCSV function * Fix method getBindingReportOperations in rest service. * create report when the binding is created * save the synchronize report correctly * Fix display of binding reports table. * make savBinding and saveReport correct * Fix display of end date. * Fix Display of table headers. * Fix display of reports table columns. * format date * display group label & fix date display * Add button for upload file. * Add function uploadCSVFile. * update report link * Fix operation type names. * simplify the getBindingReports * Fix display of reports table and make sure the filter is working and code cleanup. * Make sure the search works on space name. * make SpaceBindingReport display sync when create or remove a binding * Take care of delete groups * use correct action name for export file * update startDate and endDate column name * fix remove binding when user is deleted * make filter working * Make sure when applying binding changes to redirect to the binding reports after the erquest is fulfilled. (#40) * when deleting a groupBinding, we want the ReportAction create directly, not when the job starts * Fix-BindingReport-US11/13 : Fix search and filter in table binding reports. (#41) ** Fix binding reports table filter and search. ** Fix method buildEntityFromGroup. * when 'New Binding' label to 'Add Binding' * fix problem when a userbinding already exists, we should not duplicate it. * Fix-BinindgReport-US04: Make sure to display directly the report of synchronize when a boun group is removed. (#42) * fix reports when user leave the group and action is syncrhonize * Fix-BindingReports-UI: Update label Synchronization to Synchronize. (#43) * Fix-BindingReports-UI-01: Fix display of binding reports table. (#47) ** Fix display of reports table filter and search field. ** Fix reports table filter. ** Fix display of reports filter. * BindingReports_US04 : in report tab, do not count user still in space for remove lines * Fix-BindingReports-UI-02: Fix reports table filter. (#48) * Fix-BindingReports-UI-03: Fix alignment of space name and avatar in reports table. (#49)
rdenarie
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Binding_reports: Add sql table, entity and dao for the binding reports. * Create GroupSpaceBindingReports : ** Add GroupSpaceBindingReport object ** Add the possibility to create/delete GroupSpaceBindingReportEntity ** Add the possibility to search GroupSpaceBindingReport from (space, groupspacebinding, group, action ** Start the create the function to get the CSV file * create the export to csv file * Make cleanup : remove duplicate code * Add report binding for add action, remove action, and for update action * change relation between space and groupBindingReport, to have delete on cascade * Binding Report - add field stillInSpace * use field stillPresent in binding reports csv * Update test for testing reports and new field stillInSpace * Binding_reports: Make Binding reports table fields internationalized. * FixSocialBuild: Fix rest service test. (#34) * Problem when deleting a binding ** When a group is bound to 2 spaces, and when you delete one of theses binding, the users are removed from both spaces ** This fix changes the way we get userBinding, to get only userBinding linked to this group binding, and not link to the group name * fix comment * Fix binding process of remove user membership synchronization. * Add GroupSpaceBindingOperationReport model and rest entity. * Add method getGroupSpaceBindingReportOperations. * Add GroupSpaceBindingOperationReport model and rest entity. * Implement rest service for retrieving binding reports. * Fix method getGroupSpaceBindingReportOperations. * Fix rest service. * Add sql table for GroupSpaceBindingReportUser. * Add GroupSpaceBindingReportUserDAO. * Add GroupSpaceBindingReportUser model. * Fix the case when a userBinding is removed ** If the userBinding is removed due to groupBinding remove, ** the user should stay in space if he has other binding or if he was member before ** If the userBinding is remove because user leaves the group, ** then the user should stay in space only if he has other binding * Rename GroupSpaceBindingReportDAO. * Add the process of saving binding reports. * Add binding Process of retrieving binding reports operations. * Fix GroupSpaceBindingServiceTest. * change the function getReportsForCSV to use only one action * comment code to make it build. I will rework on it after. * Change object for GroupBindingReport * fix problem in changelog, and update ReportAction and ReportUsers to use object instead of id * update TU * Fix method buildEntityGroupSpaceBindingReportUserFrom. * add unit tests * Fix retrieving process of operationsReprot. * Fix methods updateGroupSpaceBindingReportAction and buildEntityFromGroupSpaceBindingOperationReport. * Fix GroupSpaceBindingOperationReportEntity. * Add space Etnity to the report entity. * Add methods getAllFromBindingQueue. * Complete test set * Make sure to add binding reports from the binding queue and fix ExoSpacesAdministrationBindingReports. * update the findReportForCSV function * Fix method getBindingReportOperations in rest service. * create report when the binding is created * save the synchronize report correctly * Fix display of binding reports table. * make savBinding and saveReport correct * Fix display of end date. * Fix Display of table headers. * Fix display of reports table columns. * format date * display group label & fix date display * Add button for upload file. * Add function uploadCSVFile. * update report link * Fix operation type names. * simplify the getBindingReports * Fix display of reports table and make sure the filter is working and code cleanup. * Make sure the search works on space name. * make SpaceBindingReport display sync when create or remove a binding * Take care of delete groups * use correct action name for export file * update startDate and endDate column name * fix remove binding when user is deleted * make filter working * Make sure when applying binding changes to redirect to the binding reports after the erquest is fulfilled. (#40) * when deleting a groupBinding, we want the ReportAction create directly, not when the job starts * Fix-BindingReport-US11/13 : Fix search and filter in table binding reports. (#41) ** Fix binding reports table filter and search. ** Fix method buildEntityFromGroup. * when 'New Binding' label to 'Add Binding' * fix problem when a userbinding already exists, we should not duplicate it. * Fix-BinindgReport-US04: Make sure to display directly the report of synchronize when a boun group is removed. (#42) * fix reports when user leave the group and action is syncrhonize * Fix-BindingReports-UI: Update label Synchronization to Synchronize. (#43) * Fix-BindingReports-UI-01: Fix display of binding reports table. (#47) ** Fix display of reports table filter and search field. ** Fix reports table filter. ** Fix display of reports filter. * BindingReports_US04 : in report tab, do not count user still in space for remove lines * Fix-BindingReports-UI-02: Fix reports table filter. (#48) * Fix-BindingReports-UI-03: Fix alignment of space name and avatar in reports table. (#49)
boubaker
pushed a commit
that referenced
this pull request
Jul 3, 2020
* Binding_reports: Add sql table, entity and dao for the binding reports. * Create GroupSpaceBindingReports : ** Add GroupSpaceBindingReport object ** Add the possibility to create/delete GroupSpaceBindingReportEntity ** Add the possibility to search GroupSpaceBindingReport from (space, groupspacebinding, group, action ** Start the create the function to get the CSV file * create the export to csv file * Make cleanup : remove duplicate code * Add report binding for add action, remove action, and for update action * change relation between space and groupBindingReport, to have delete on cascade * Binding Report - add field stillInSpace * use field stillPresent in binding reports csv * Update test for testing reports and new field stillInSpace * Binding_reports: Make Binding reports table fields internationalized. * FixSocialBuild: Fix rest service test. (#34) * Problem when deleting a binding ** When a group is bound to 2 spaces, and when you delete one of theses binding, the users are removed from both spaces ** This fix changes the way we get userBinding, to get only userBinding linked to this group binding, and not link to the group name * fix comment * Fix binding process of remove user membership synchronization. * Add GroupSpaceBindingOperationReport model and rest entity. * Add method getGroupSpaceBindingReportOperations. * Add GroupSpaceBindingOperationReport model and rest entity. * Implement rest service for retrieving binding reports. * Fix method getGroupSpaceBindingReportOperations. * Fix rest service. * Add sql table for GroupSpaceBindingReportUser. * Add GroupSpaceBindingReportUserDAO. * Add GroupSpaceBindingReportUser model. * Fix the case when a userBinding is removed ** If the userBinding is removed due to groupBinding remove, ** the user should stay in space if he has other binding or if he was member before ** If the userBinding is remove because user leaves the group, ** then the user should stay in space only if he has other binding * Rename GroupSpaceBindingReportDAO. * Add the process of saving binding reports. * Add binding Process of retrieving binding reports operations. * Fix GroupSpaceBindingServiceTest. * change the function getReportsForCSV to use only one action * comment code to make it build. I will rework on it after. * Change object for GroupBindingReport * fix problem in changelog, and update ReportAction and ReportUsers to use object instead of id * update TU * Fix method buildEntityGroupSpaceBindingReportUserFrom. * add unit tests * Fix retrieving process of operationsReprot. * Fix methods updateGroupSpaceBindingReportAction and buildEntityFromGroupSpaceBindingOperationReport. * Fix GroupSpaceBindingOperationReportEntity. * Add space Etnity to the report entity. * Add methods getAllFromBindingQueue. * Complete test set * Make sure to add binding reports from the binding queue and fix ExoSpacesAdministrationBindingReports. * update the findReportForCSV function * Fix method getBindingReportOperations in rest service. * create report when the binding is created * save the synchronize report correctly * Fix display of binding reports table. * make savBinding and saveReport correct * Fix display of end date. * Fix Display of table headers. * Fix display of reports table columns. * format date * display group label & fix date display * Add button for upload file. * Add function uploadCSVFile. * update report link * Fix operation type names. * simplify the getBindingReports * Fix display of reports table and make sure the filter is working and code cleanup. * Make sure the search works on space name. * make SpaceBindingReport display sync when create or remove a binding * Take care of delete groups * use correct action name for export file * update startDate and endDate column name * fix remove binding when user is deleted * make filter working * Make sure when applying binding changes to redirect to the binding reports after the erquest is fulfilled. (#40) * when deleting a groupBinding, we want the ReportAction create directly, not when the job starts * Fix-BindingReport-US11/13 : Fix search and filter in table binding reports. (#41) ** Fix binding reports table filter and search. ** Fix method buildEntityFromGroup. * when 'New Binding' label to 'Add Binding' * fix problem when a userbinding already exists, we should not duplicate it. * Fix-BinindgReport-US04: Make sure to display directly the report of synchronize when a boun group is removed. (#42) * fix reports when user leave the group and action is syncrhonize * Fix-BindingReports-UI: Update label Synchronization to Synchronize. (#43) * Fix-BindingReports-UI-01: Fix display of binding reports table. (#47) ** Fix display of reports table filter and search field. ** Fix reports table filter. ** Fix display of reports filter. * BindingReports_US04 : in report tab, do not count user still in space for remove lines * Fix-BindingReports-UI-02: Fix reports table filter. (#48) * Fix-BindingReports-UI-03: Fix alignment of space name and avatar in reports table. (#49)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.