This repository was archived by the owner on Feb 24, 2026. It is now read-only.
[chore] Simplify @expo/steps from dual ESM/CJS to plain CJS#658
Merged
[chore] Simplify @expo/steps from dual ESM/CJS to plain CJS#658
Conversation
hSATAC
approved these changes
Jan 12, 2026
Contributor
hSATAC
left a comment
hSATAC
left a comment
There was a problem hiding this comment.
I am going to have a rebase hell after this was merged. 😭
Contributor
Author
|
oh no maybe |
Contributor
Author
|
hmm most of your changes are in |
- Remove 'type: module' field - Simplify main/types to use single dist/ directory - Remove dual exports field - Update build scripts to use simple tsc - Remove chokidar-cli (no longer needed for watch) - Remove this-file dependency (replaced with native __dirname)
- Update tsconfig.build.json to use commonjs module and output to dist/ - Delete tsconfig.build.commonjs.json (no longer need dual build) - Delete build.sh (replaced by simple tsc command in package.json)
Remove ESM-style .js extensions from all relative imports in source files. CommonJS module resolution doesn't require explicit extensions.
- Replace this-file createContext() with native __dirname - Remove import.meta.url usage in test files (use built-in __dirname) - Update SCRIPTS_PATH to point to dist/scripts instead of dist_commonjs/scripts
- Update cli.sh to reference dist/cli/cli.js instead of dist_commonjs/cli/cli.cjs - Simplify jest.config.cjs to use standard ts-jest preset (not ESM) - Remove moduleNameMapper for .js extensions (no longer needed) - Remove custom transform with useESM option
- Remove this-file import from runCustomFunction-test.ts - Update SCRIPTS_PATH reference to runCustomFunction.js (not .cjs)
sjchmiela
force-pushed
the
sjchmiela/simplify-steps-to-cjs
branch
from
c9fcd40 to
2dc1aaa
Compare
Contributor
Author
|
Going to publish steps as v2 so it doesn't break anyone's code (specifically, user functions created with |
Contributor
Author
|
Or… maybe we don't need to do that because functions are commonjs? |
hSATAC
approved these changes
Jan 23, 2026
Contributor
hSATAC
left a comment
hSATAC
left a comment
There was a problem hiding this comment.
I don't find anything left out. This looks generally good to me.
sjchmiela
added a commit
to expo/eas-cli
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
@expo/stepspackage was configured with a dual ESM/CJS build setup that added unnecessary complexity:tsconfig.build.jsonandtsconfig.build.commonjs.json)build.shscript that usedsedto rename.jsfiles to.cjsthis-filepackage andimport.meta.url.jsextensions required on all importsThis complexity was not needed as the package runs in Node.js where CJS is well supported, and other packages in the workspace (like
@expo/eas-build-job) use plain CJS successfully and we're not planning to move off of CJS without moving all the rest of the packages to ESM too. Having this package as the only package with ESM enabled is a bit weird.How
"type": "module"frompackage.jsonmainandtypesfields pointing todist/tsconfig.build.jsonusingmodule: \"commonjs\"build.shscript and replaced with simpletsccommand.jsextensions from all import statements (~40 files)this-filepackage usage with native__dirnameimport.meta.urlwith__dirnameequivalentsts-jestpresetcli.shto point todist/cli/cli.jsthis-fileandchokidar-clidev dependenciesTest Plan
yarn buildcompletes successfullyyarn testpasses all 281 tests across 20 test suites