Skip to content

Comments

fix: Reorganize constructionUtils to make non-public#454

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-16-fix_reorganize_constructionutils_to_make_non-public
Feb 17, 2026
Merged

fix: Reorganize constructionUtils to make non-public#454
wschurman merged 1 commit intomainfrom
wschurman/02-16-fix_reorganize_constructionutils_to_make_non-public

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 17, 2026

Why

In #410 we split out EntityLoaderUtils into two classes:

  • EntityInvalidationUtils - functions for invalidating entity caches from application code when underlying data is mutated outside of the entity framework
  • EntityConstructorUtils - functions for constructing and authorizing entities.

Originally, these were both public due to them being the same class. Now, with them separated, we can better restrict access to entity construction which should only be done within the framework itself.

How

Make constructor utils private everywhere except EntityLoaderFactory, which is deep enough in the abstraction that it's not immediately usable by top-level entity APIs (static methods on Entity/ReadonlyEntity, loader classes).

Test Plan

yarn tsc, CI

Copy link
Member Author

wschurman commented Feb 17, 2026

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (457f58a) to head (f8fb354).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #454    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          109       109            
  Lines        15944     15974    +30     
  Branches       861      1432   +571     
==========================================
+ Hits         15944     15974    +30     
Flag Coverage Δ
integration 23.40% <0.00%> (-0.05%) ⬇️
unittest 95.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman requested review from ide and quinlanj February 17, 2026 17:08
@wschurman wschurman marked this pull request as ready for review February 17, 2026 17:08
Copy link
Member Author

wschurman commented Feb 17, 2026

Merge activity

  • Feb 17, 10:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 17, 10:40 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman merged commit d9377a2 into main Feb 17, 2026
6 checks passed
@wschurman wschurman deleted the wschurman/02-16-fix_reorganize_constructionutils_to_make_non-public branch February 17, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants