fix: validate fileSize is integer to prevent limit bypass#1395
Open
abhu85 wants to merge 1 commit intoexpressjs:mainfrom
Open
fix: validate fileSize is integer to prevent limit bypass#1395abhu85 wants to merge 1 commit intoexpressjs:mainfrom
abhu85 wants to merge 1 commit intoexpressjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate that
fileSizelimit is an integer to prevent silent limit bypass with floating-point values.Problem
When
limits.fileSizeis a floating-point number (e.g.,1024.1), busboy does not enforce the limit correctly, allowing files larger than intended to be uploaded.Solution
Add input validation in the
Multerconstructor to throw aTypeErroriffileSizeis not an integer, matching the behavior in multer v3. The check usesNumber.isInteger()and only applies whenfileSizeis explicitly provided (non-null).Test Plan
fileSize: 1024.5throws TypeErrorfileSize: 1024works normallyFixes #1132