Conversation
Fix tests suites
Conflicts: package.json
package.json
Outdated
| "build:development": "NODE_ENV=development yarn run webpack --progress --mode development", | ||
| "build:production": "rm -rf ./dist/ && NODE_ENV=production env=production yarn run webpack", | ||
| "build:development": "yarn run webpack --env ${NODE_ENV:-development}", | ||
| "build:production": "rm -rf ./dist/ && yarn run webpack --env ${NODE_ENV:-production}", |
There was a problem hiding this comment.
Hi!, here we forced NODE_ENV production because the task is named build:production, with that update now you can build a production version with a development env. Is what you want? Maybe you can try to make a generic build script with the node_env variable with that parameter :D
There was a problem hiding this comment.
Make sense, we could assume that when running the default build the environment is prod, merging the two tasks, something like this:
build: "rm -rf ./dist/ && yarn run webpack --env ${NODE_ENV:-production}".
What do you think?
package.json
Outdated
| { | ||
| "name": "beccaccino", | ||
| "version": "2.0.0", | ||
| "version": "2.0.0-upgrade-dephs.0", |
There was a problem hiding this comment.
Maybe it's a typo? You mean deps?
There was a problem hiding this comment.
Hi @CDimonaco! Yes, thank you, fortunately, I haven't published yet :)
Also upgrade build script
2 participants
No description provided.