Conversation
extractive-mana-pulse
left a comment
extractive-mana-pulse
left a comment
There was a problem hiding this comment.
Need to rework all these pending comments
There was a problem hiding this comment.
Fix dependencies. use only needed ones and get rid of all others
There was a problem hiding this comment.
Get Rid of comments. fix dependencies if needed
There was a problem hiding this comment.
Hard coded values, fix them
There was a problem hiding this comment.
Hardcoded values, function visibility keyword.
| is LoginState.Idle -> {} | ||
| is LoginState.Loading -> {} |
There was a problem hiding this comment.
instead leaving it empty, make it else -> Unit
| Box( | ||
| modifier = Modifier.fillMaxSize(), | ||
| contentAlignment = Alignment.Center | ||
| ) { | ||
| CircularProgressIndicator() | ||
| } |
There was a problem hiding this comment.
Come up with loading extension
| Toast.makeText( | ||
| context, | ||
| "This page is not available yet!", | ||
| Toast.LENGTH_SHORT | ||
| ).show() |
There was a problem hiding this comment.
use extension of a toast
| } else { | ||
| SettingsContent( | ||
| onLogoutClick = { | ||
| loginViewModel.logoutUser(refreshToken = refreshToken ?: "") |
There was a problem hiding this comment.
Fix the action, do MVI
There was a problem hiding this comment.
polish the code
There was a problem hiding this comment.
re design this vm from scratch
1 participant
In this mart of issue of the modularization. we've done fixing code and implementing camouflage for status bar which is not fully done yet. so after merging this pr, next step going to be fixing camouflage.