Skip to content

Conversation

@krishjp
Copy link

@krishjp krishjp commented Nov 15, 2025

  • Increased testing suite depth with shape and consistency tests
  • Updated toml file with an updated version of nbmake to remove warning messages running nbmake on windows:
  • "UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81."
    
  • Added slow marker config to toml file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes seem fine, but I would separate out the conditional test additions to another PR. I will have to review the code and determine if these tests are warranted (regardless they should also be adjusted to match the style of the other tests)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll make another PR for the tests and adjust them to match styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants