Conversation
…ith runners with ubuntu-latest Co-authored-by: exzosverse-os <248856943+exzosverse-os@users.noreply.github.com>
ci: deploy strategy main→production, develop→preview; replace blacksmith runners
…cret When the IPINFO_ACCESS_TOKEN secret is not configured in the repository, BuildKit doesn't create the secret mount at /run/secrets/IPINFO_ACCESS_TOKEN. The build then fails with: cat: can't open '/run/secrets/IPINFO_ACCESS_TOKEN': No such file or directory This change adds a conditional check for the secret file existence before attempting to read it. If the secret is not available, the build continues with a warning and skips the IPInfo database download. Co-authored-by: exzosverse-os <248856943+exzosverse-os@users.noreply.github.com>
…secret fix: make Docker build resilient to missing IPINFO_ACCESS_TOKEN secret
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Summary of ChangesHello @exzosverse-os, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's deployment and build processes. It updates the Vercel configuration to streamline web application deployments by restricting automatic builds to the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
exzosverse-os
had a problem deploying
to
production
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
This PR implements a dual-branch deployment strategy, migrates from Blacksmith to standard GitHub runners, and makes the IPInfo database download optional during Docker builds.
Changes:
- Enables independent deployments for both
main(production) anddevelop(sandbox/preview) branches - Migrates all GitHub Actions workflows from Blacksmith runners to
ubuntu-latest - Makes IPInfo database download optional in Docker builds when IPINFO_ACCESS_TOKEN is not provided
- Updates Vercel configuration to deploy from both
mainanddevelopbranches
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/Dockerfile | Adds conditional logic to skip IPInfo database download when token is unavailable, creating empty /data directory instead |
| clients/apps/web/vercel.json | Updates ignoreCommand to allow deployments from both main and develop branches |
| .github/workflows/test_server.yaml | Migrates all jobs from blacksmith-4vcpu-ubuntu-2404 to ubuntu-latest |
| .github/workflows/test_client.yaml | Migrates both jobs from blacksmith-4vcpu-ubuntu-2404 to ubuntu-latest |
| .github/workflows/terraform.yaml | Migrates lint job from blacksmith-2vcpu-ubuntu-2404 to ubuntu-latest |
| .github/workflows/deploy.yml | Enables develop branch triggers, adds branch-specific concurrency groups, migrates to ubuntu-latest and official Docker actions, makes deploy-sandbox and deploy-production independent with branch-specific conditions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| curl -fsSL "https://ipinfo.io/data/free/country_asn.mmdb?token=${TOKEN}" -o /data/country_asn.mmdb && \ | ||
| echo "${EXPECTED_SHA256} /data/country_asn.mmdb" | sha256sum -c - ; \ | ||
| else \ | ||
| echo "WARNING: IPINFO_ACCESS_TOKEN not provided, skipping IPInfo database download" ; \ |
There was a problem hiding this comment.
When IPINFO_ACCESS_TOKEN is not provided, the /data directory is created but remains empty. The COPY command at a later stage (COPY --from=download-ipinfo /data /data) will still succeed, but the application will receive an empty directory. This is actually handled correctly by the application code (server/polar/app.py lines 147-154), which gracefully handles the FileNotFoundError. However, it would be clearer to create a marker file or document this behavior explicitly in a comment to indicate that the empty directory is intentional for builds without the token.
| echo "WARNING: IPINFO_ACCESS_TOKEN not provided, skipping IPInfo database download" ; \ | |
| echo "WARNING: IPINFO_ACCESS_TOKEN not provided, skipping IPInfo database download" && \ | |
| # Create a marker file so that the empty /data directory is clearly intentional | |
| touch /data/IPINFO_DATABASE_NOT_DOWNLOADED ; \ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces changes to Vercel deployment configuration and Dockerfile for the server. The Vercel configuration now includes the 'develop' branch in the ignore command, which is a good practice for managing deployments. The Dockerfile changes improve the IPInfo database download process by making it conditional on the presence of an access token, which enhances flexibility and error handling during builds. Overall, the changes are positive for deployment and build robustness.
| "$schema": "https://openapi.vercel.sh/vercel.json", | ||
| "buildCommand": "cd ../.. && turbo run build --filter=web", | ||
| "ignoreCommand": "if [ \"$VERCEL_GIT_COMMIT_REF\" != \"main\" ]; then exit 0; fi; npx turbo-ignore", | ||
| "ignoreCommand": "if [ \"$VERCEL_GIT_COMMIT_REF\" != \"main\" ] && [ \"$VERCEL_GIT_COMMIT_REF\" != \"develop\" ]; then exit 0; fi; npx turbo-ignore", |
There was a problem hiding this comment.
Adding develop to the ignoreCommand is a good practice to prevent unnecessary deployments from the develop branch, aligning with typical CI/CD workflows where only main or specific release branches trigger production deployments.
"ignoreCommand": "if [ \"$VERCEL_GIT_COMMIT_REF\" != \"main\" ] && [ \"$VERCEL_GIT_COMMIT_REF\" != \"develop\" ]; then exit 0; fi; npx turbo-ignore"
📋 Summary
Related Issue: Fixes #
🎯 What
🤔 Why
🔧 How
🧪 Testing
uv run task testfor backend,pnpm testfor frontend)uv run task lint && uv run task lint_typesfor backend)Test Instructions
🖼️ Screenshots/Recordings
📝 Additional Notes
✅ Pre-submission Checklist