Open
Conversation
Vite does not type check in dev mode, only in build mode.
I implemented a file system API for Tauri that lets us access and modify arbitrary parts of the file system, instead of the limited scope that the `tauri.fs` provides us. This involved exposing much of Rust's `std::io` via the `tauri::command` proc macro, and then reading these functions into the TS side. Also, I created the function definitions for the WASM side's filesystem, but I haven't implemented it yet because I don't totally understand browser local storage works in WASM.
Currently, our file system function to read a directory fails to inform the front-end whether a path leads to a file or a directory. As such, I have added a boolean to each output with this information. Also, renamed copy to copy_file for consistency, clarity, and compatibility with the initial interface.
# Conflicts: # src/components/Code.jsx
# Conflicts: # package.json # src/components/Code.jsx # src/rust_functions.ts # tailwind.config.js # tsconfig.json
It turns out you can use multiple handler invokers, so I combined them into one big handler.
AleksBekker
requested changes
Aug 9, 2024
Collaborator
AleksBekker
left a comment
AleksBekker
left a comment
There was a problem hiding this comment.
After file_system.ts was renamed to tauri_file_system.ts, it is now the case that the WASM file system depends on a Tauri file system module. Please create an issue to move the FileSystem interface into a file_system.ts file and commit the changes
AleksBekker
approved these changes
Sep 23, 2024
Collaborator
AleksBekker
left a comment
AleksBekker
left a comment
There was a problem hiding this comment.
I don't understand much of the front end React stuff, but the "back end" stuff looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is basically what I've been working on the entire semester, getting a filesystem implementation working).
Filesystem support
The filesystem does not actually work with the editor yet, although that's a future plan.