-
Notifications
You must be signed in to change notification settings - Fork 0
HW5 is completed #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ezhk
wants to merge
7
commits into
master
Choose a base branch
from
hw05_parallel_execution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
79f894e
HW5 is completed
758d8bd
remove unused comment
1507899
atomic decrement errors
bb3ff5e
atomic decrement errors: remove unused variable
aa30d9f
update code style
a02193e
race fix: use WaitGroup
4d30fa5
update with gofumpt
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,14 +2,56 @@ package hw05_parallel_execution //nolint:golint,stylecheck | |
|
|
||
| import ( | ||
| "errors" | ||
| "sync" | ||
| "sync/atomic" | ||
| ) | ||
|
|
||
| var ErrErrorsLimitExceeded = errors.New("errors limit exceeded") | ||
| var ( | ||
| ErrErrorsLimitExceeded = errors.New("errors limit exceeded") | ||
| ErrGoroutinesLimitNonPositive = errors.New("goroutines limit contains non positive value") | ||
| ErrErrorsAmountNonPositive = errors.New("errors amount contains non positive value") | ||
| ) | ||
|
|
||
| type Task func() error | ||
|
|
||
| // Run starts tasks in N goroutines and stops its work when receiving M errors from tasks | ||
| func Run(tasks []Task, N int, M int) error { | ||
| // Place your code here | ||
| func Run(tasks []Task, goroutinesLimit, maxErrors int) error { | ||
| if goroutinesLimit < 1 { | ||
| return ErrGoroutinesLimitNonPositive | ||
| } | ||
| if maxErrors < 1 { | ||
| return ErrErrorsAmountNonPositive | ||
| } | ||
|
|
||
| errorsLeft := int64(maxErrors) | ||
| concurrentCh := make(chan struct{}, goroutinesLimit) | ||
| defer close(concurrentCh) | ||
|
|
||
| var wg sync.WaitGroup | ||
| for _, task := range tasks { | ||
| if atomic.LoadInt64(&errorsLeft) < 1 { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: в https://github.com/uber-go/atomic есть API поприятнее |
||
| break | ||
| } | ||
|
|
||
| // wait for next step: use channel as task queue | ||
| concurrentCh <- struct{}{} | ||
|
|
||
| wg.Add(1) | ||
| go func(t Task) { | ||
| defer func() { | ||
| <-concurrentCh | ||
| wg.Done() | ||
| }() | ||
|
|
||
| if err := t(); err != nil { | ||
| atomic.AddInt64(&errorsLeft, -1) | ||
| } | ||
| }(task) | ||
| } | ||
| wg.Wait() | ||
|
|
||
| if errorsLeft < 1 { | ||
| return ErrErrorsLimitExceeded | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачем?