Open
Conversation
andrerom
suggested changes
Dec 29, 2017
Contributor
andrerom
left a comment
andrerom
left a comment
There was a problem hiding this comment.
Besides needs for fixing the inline text here it looks good.
But I would make one change to the logic, make all meta data fields optional and just make sure at least one is specified before doing the update.
(implies the values set on $contentMetadataUpdateStruct should be conditional)
| $this->setName( 'ezpublish:cookbook:update_content_metadata' )->setDefinition( | ||
| array( | ||
| new InputArgument( 'contentId' , InputArgument::REQUIRED, 'the content to be updated' ), | ||
| new InputArgument( 'newOwnerId' , InputArgument::REQUIRED, 'the new title of the content' ), |
Contributor
There was a problem hiding this comment.
the new title of the content => new owner for the content
Also should be made optional
| array( | ||
| new InputArgument( 'contentId' , InputArgument::REQUIRED, 'the content to be updated' ), | ||
| new InputArgument( 'newOwnerId' , InputArgument::REQUIRED, 'the new title of the content' ), | ||
| new InputArgument( 'newModificationDate' , InputArgument::REQUIRED, 'the new body of the content' ), |
Contributor
There was a problem hiding this comment.
the new body of the content => new modification date for the content
Also should be made optional
| new InputArgument( 'contentId' , InputArgument::REQUIRED, 'the content to be updated' ), | ||
| new InputArgument( 'newOwnerId' , InputArgument::REQUIRED, 'the new title of the content' ), | ||
| new InputArgument( 'newModificationDate' , InputArgument::REQUIRED, 'the new body of the content' ), | ||
| new InputArgument( 'newPublishedDate' , InputArgument::REQUIRED, 'the new body of the content' ), |
Contributor
There was a problem hiding this comment.
the new body of the content => new publish date for the content
Also should be made optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New command to update some content metadata (owner, published date and modification date).