Skip to content

added class check when deleteDocs in multishard setup #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilukac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added class check when deleteDocs in multishard setup #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion search/plugins/ezsolr/ezsolr.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,8 @@ public function removeObjectById( $contentObjectId, $commit = null )
{
foreach ( $docs as $languageCode => $doc )
{
$this->SolrLanguageShards[$languageCode]->deleteDocs( array( $doc ), false, $commit, $optimize );
if ($this->SolrLanguageShards[$languageCode] instanceof eZSolrBase )
Copy link
Contributor

@bdunogier bdunogier Apr 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS: space after "("

Copy link
Author

@ilukac ilukac Apr 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicker :P

Copy link
Contributor

@bdunogier bdunogier Apr 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what ? ;-)

If this had been on one of the bigger repos, ezrobot would have said it, and not in a nice way ;-)

$this->SolrLanguageShards[$languageCode]->deleteDocs( array( $doc ), false, $commit, $optimize );
}
}
else
Expand Down