All subsequent calls now uses ezpublish/console if applicable. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I haven't tried it myself, but do you know if this will still work on Legacy (only) installs? |
Author
|
I have verified that the global "input" does not exist for legacy, so the executable should be set correctly. The only thing that worries me is that I had to remove escapeshellarg for the siteaccess-parameter. I tried to run the script the legacy-way and it did spawn it's threads as usual. If you are considering a merge, I can ask if a colleague of mine can test it on a legacy-only install. |
Author
|
The use-statement would have caused problems, so I removed it. |
Contributor
|
This looks pretty hackish, but I don't have suggestions for how to deal with forking in legacy scripts in a better way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EZP-21800. Code might not be perfect, but it should demonstrate what the issue entails.