Fix EZP-29608: better output of updateserachindexsolr #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
suggested changes
Jan 26, 2017
Contributor
bdunogier
left a comment
bdunogier
left a comment
There was a problem hiding this comment.
No problem for me besides the review remarks.
But No description provided., please... :)
bin/php/updatesearchindexsolr.php
Outdated
| { | ||
| if ( $this->CLI->isQuiet() ) | ||
| return; | ||
| //print( $string ); |
bin/php/updatesearchindexsolr.php
Outdated
| //print( $string ); | ||
| fwrite(STDOUT, $string); | ||
| if ( $addEOL ) | ||
| //print( $this->endlineString() ); |
Contributor
There was a problem hiding this comment.
To remove.
Why did you use fwrite(STDOUT) instead of $this->CLI ?
Contributor
Author
There was a problem hiding this comment.
It's described in the related issue :-P
In short: STDOUT avoids problems with ob_start and friends. Without it, the output of the script becomes messy, at least when run thru ezp/console: some lines get repeated twice or even more, at different points in time)
gggeek
force-pushed
the
EZP-26908-rebase
branch
from
cddb84d to
ebc93d3
Compare
Contributor
Author
|
Comments taken into account. Also added more info on the issue at https://jira.ez.no/browse/EZP-26908 |
Contributor
Author
|
ping |
Contributor
Author
|
Anyone up for review ? |
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default updateserachindex solr output is all mixed up and duplicated when run via ezpublish/console. This PR fixes that