Skip to content

Better building of highlighting parameters #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gggeek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better building of highlighting parameters #214

gggeek wants to merge 1 commit into from

Conversation

@gggeek
Copy link
Contributor

@gggeek gggeek commented Mar 18, 2018

  • do not inject any hl parameter unless needed
  • make it easier to alter build of hl parameters in subclasses

@gggeek gggeek force-pushed the gg/better_highlighting branch from bc9db6d to e41c2ee Compare March 18, 2018 19:46
avoid sending *any* hl parameter to solr when not required & make it …
775ea98 
…easy to extend hl param build in subclasses
@gggeek gggeek force-pushed the gg/better_highlighting branch from e41c2ee to 775ea98 Compare March 18, 2018 19:50
@pkamps
Copy link
Contributor

pkamps commented Mar 24, 2018

I like it. ezfind has so much potential for those types of enhancements.
+1

@pkamps pkamps mentioned this pull request Jun 10, 2018
Merged
@peterkeung peterkeung mentioned this pull request Aug 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crevillo crevillo crevillo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gggeek @pkamps @crevillo