Skip to content

Conversation

@pbek
Copy link

@pbek pbek commented Sep 21, 2018

Fixes:

 PHP | File:Line                                                                                          |             Type | Issue
 7.0 | /bin/php/updatesearchindexsolr.php:64                                                              | method_name      | Method name ezfUpdateSearchIndexSolr:ezfUpdateSearchIndexSolr (@php4_constructors) is deprecated. 
 7.0 | /classes/ezfezpsolrquerybuilder.php:17                                                             | method_name      | Method name ezfeZPSolrQueryBuilder:ezfeZPSolrQueryBuilder (@php4_constructors) is deprecated. 
 7.0 | /classes/ezfindresultnode.php:13                                                                   | method_name      | Method name eZFindResultNode:eZFindResultNode (@php4_constructors) is deprecated. 
 7.0 | /classes/ezfindresultobject.php:13                                                                 | method_name      | Method name eZFindResultObject:eZFindResultObject (@php4_constructors) is deprecated. 
 7.0 | /classes/ezfmodulefunctioncollection.php:17                                                        | method_name      | Method name ezfModuleFunctionCollection:ezfModuleFunctionCollection (@php4_constructors) is deprecated. 
 7.0 | /classes/ezfsearchresultinfo.php:27                                                                | method_name      | Method name ezfSearchResultInfo:ezfSearchResultInfo (@php4_constructors) is deprecated. 

@andrerom
Copy link
Contributor

andrerom commented Oct 3, 2018

@gggeek's comment on constructor BC is also valid here if we want to backport this fix, alternative is that we do a v2018.09.0 release, then it's not a must.

Any opinions? @gggeek @crevillo

@gggeek
Copy link
Contributor

gggeek commented Oct 3, 2018

Indeed: +1 for adding BC constructor methods

@pkamps
Copy link
Contributor

pkamps commented Nov 10, 2018

+1 - additional BC constructor methods would be nice. So 2 constructor methods - something like this:

function ezfUpdateSearchIndexSolr( eZScript $script, eZCLI $cli, $executedScript ){ ... }
function __construct( eZScript $script, eZCLI $cli, $executedScript ){ ... }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants