Custom class-attributes indexing #222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkamps
reviewed
Dec 3, 2019
| foreach ( $tmpNodeRowList as $nodeRow ) | ||
| { | ||
| $nodeRowList[$nodeRow['node_id']] = $nodeRow; | ||
|
|
Contributor
There was a problem hiding this comment.
Why it that code required? Also, it has nothing to do with what the pull request describes, right?
| $objectAttribute->attribute('contentclass_attribute_identifier') | ||
| ); | ||
| if (array_key_exists($identifierComposite, $attributeMapList)) { | ||
| return self::$singletons[$objectAttribute->attribute('id')] = new $attributeMapList[$identifierComposite]($objectAttribute); |
Contributor
There was a problem hiding this comment.
Maybe check if the class really exists. Not sure but trying to get an instance of a non-existing class is probably throwing a fatal error?
Is that self::$singletons used anywhere?
| } | ||
| } | ||
|
|
||
| $customAttributeMap = $eZFindIni->variable('SolrFieldMapSettings', 'CustomAttributeMap'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for indexing specific attributes on classes using the CustomAttributeMap setting that was never properly/finished developed.