feat: implement support for monitoring D-Bus signals#63
Merged
f-person merged 6 commits intof-person:masterfrom Mar 28, 2026
Merged
feat: implement support for monitoring D-Bus signals#63f-person merged 6 commits intof-person:masterfrom
f-person merged 6 commits intof-person:masterfrom
Conversation
FineFindus
force-pushed
the
feat/monitor-dbus
branch
3 times, most recently
from
2a10a42 to
e01d9c8
Compare
Implements support for using `dbus-monitor`, which allows direct monitoring of signals, which are send when the settings changes. This reduces the system load, as continuous polling is no longer required, as well as improving the responsiveness, as the theme is now updated immediately, instead of waiting for the next polling-cycle to complete. If `dbus-monitor` is not available, the polling method will be used as a fallback.
FineFindus
force-pushed
the
feat/monitor-dbus
branch
from
e01d9c8 to
dc2fa21
Compare
|
Tested this change and it works great! With the current implementation (using |
aliaksandr-trush
suggested changes
Sep 22, 2025
Contributor
Author
|
This should also solve #64. |
aliaksandr-trush
approved these changes
Sep 23, 2025
|
@FineFindus thanks for the solution. I've found a bug - after neovim instance is closed, the created The fix is here: x1unix@138a39a For example, I restarted my neovim 3 times and got 2 orphan 
|
FineFindus
added a commit
to FineFindus/auto-dark-mode.nvim
that referenced
this pull request
Mar 27, 2026
Avoids the dbus-monitor process staying alive after exiting, thus leaking the resource. Ref: neovim/neovim#29475 Ref: f-person#63 (comment)
FineFindus
added a commit
to FineFindus/auto-dark-mode.nvim
that referenced
this pull request
Mar 27, 2026
Avoids the dbus-monitor process staying alive after exiting, thus leaking the resource. Ref: neovim/neovim#29475 Ref: f-person#63 (comment)
FineFindus
force-pushed
the
feat/monitor-dbus
branch
from
8f84f44 to
f53781c
Compare
FineFindus
added a commit
to FineFindus/auto-dark-mode.nvim
that referenced
this pull request
Mar 27, 2026
Avoids the dbus-monitor process staying alive after exiting, thus leaking the resource. Ref: neovim/neovim#29475 Ref: f-person#63 (comment)
FineFindus
force-pushed
the
feat/monitor-dbus
branch
from
f53781c to
3521995
Compare
Avoids the dbus-monitor process staying alive after exiting, thus leaking the resource. Ref: neovim/neovim#29475 Ref: f-person#63 (comment)
Contributor
Author
|
Thanks for the notice and the fix. This seems to be a Neovim bug, which only affects |
FineFindus
force-pushed
the
feat/monitor-dbus
branch
from
3521995 to
e917a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for using
dbus-monitor, which allows direct monitoring of signals, which are send when the settings changes.This reduces the system load, as continuous polling is no longer required, as well as improving the responsiveness, as the theme is now updated immediately, instead of waiting for the next polling-cycle to complete.
If
dbus-monitoris not available, the polling method will be used as a fallback.Screencast.From.2025-08-03.10-29-43.mp4