Open
Conversation
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
WoodenMaiden
force-pushed
the
feature/tests-agent
branch
from
26de47b to
8001149
Compare
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
Signed-off-by: WoodenMaiden <yann.pomie@laposte.net>
alexis-langlet
requested changes
Nov 30, 2023
| } | ||
|
|
||
| pub async fn register(&mut self, port: u16) -> Result<String> { | ||
| #[tonic::async_trait] |
There was a problem hiding this comment.
I would have used tokio async_trait here
| assert_eq!(code_return.exit_code, 1); | ||
| } | ||
|
|
||
| /// Test the creation of a file |
There was a problem hiding this comment.
Is that really what it is testing?
|
|
||
| string | ||
| #[test] | ||
| fn run_one_works_with_ouputs_and_code() { |
There was a problem hiding this comment.
Personally I tend to prefix all test function's names with 'test_' to easily differentiate it from other functions and to make sure that I specify in the name what it is supposed to test
|
|
||
| /// Test the creation of a file | ||
| #[test] | ||
| fn workload_runs_correctly() { |
There was a problem hiding this comment.
What is a workload supposed to be?
| } | ||
|
|
||
| fn default_workspace_path() -> String { | ||
| std::env::temp_dir().to_str().unwrap().to_string() |
There was a problem hiding this comment.
.to_str().unwrap().to_string() seems a bit ugly :/
|
|
||
| impl LambdoAgentServer { | ||
| pub async fn new(config: AgentConfig) -> Self { | ||
| pub async fn new<C: ClientTrait + SelfCreatingClientTrait + 'static>( |
There was a problem hiding this comment.
I really don't like the idea of a SelfCreatingClientTrait.
For me, we should do that a bit differently:
- LambdoAgentServer::new() should take a ClientTrait as a parameter
- ClientTrait should have a config() function that would be called in LambdoAgentServer::new()
That would probably reduce the complexity by a lot IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.