feat: add WearOS connector#63
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| * @param cb Optional callback invoked on success. | ||
| * @param errCb Optional callback invoked on error. | ||
| */ | ||
| send(message: Payload, cb?: ReplyCallback, errCb?: ErrorCallback) { |
There was a problem hiding this comment.
[P1] Pass required callbacks when delegating to sendMessage
The new helper declares cb and errCb as optional, but forwards them directly to sendMessage. sendMessage’s signature requires both callbacks, so under the repo’s strict TypeScript configuration this call produces TS2345: Argument of type 'ReplyCallback | undefined' is not assignable to parameter of type 'ReplyCallback' and the package no longer type-checks. Provide defaults or narrow the values before calling sendMessage so the build can succeed.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
yarn lint src/wearos/WearOSConnector.ts src/index.tsx(fails: ESLint couldn't find the plugin "eslint-plugin-ft-flow")yarn test(fails: Cannot find module '@react-native/babel-preset')https://chatgpt.com/codex/tasks/task_e_68b7027861988320a0f0cb9e5a60ce62