feat: add Mi Band connector#65
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| export const mibandEvents: WatchEvents = { | ||
| addListener, |
There was a problem hiding this comment.
[P1] Export Mi Band connector through public API
The new MiBandConnector declares and exports mibandEvents, but nothing in the package imports or re‑exports it. watchEvents in subscriptions.ts still uses the existing native module, so consumers loading react-native-wear-connectivity cannot subscribe to Mi Band events despite the new README/docs. As written this code is dead and the added dependency brings no usable feature. Consider wiring the connector into watchEvents or re-exporting it from the library entry point so callers can actually receive Mi Band data.
Useful? React with 👍 / 👎.
Summary
watchEventsTesting
yarn lint(fails: ESLint couldn't find the plugin "eslint-plugin-ft-flow")yarn typecheckyarn test(fails: Cannot find module '@react-native/babel-preset')https://chatgpt.com/codex/tasks/task_e_68b70274f8848320a3cca865b567ffb2