Skip to content

Make reset explicit and public#65

Merged
fabfuel merged 1 commit intofabfuel:developfrom
dzherb:add_reset
Mar 12, 2025
Merged

Make reset explicit and public#65
fabfuel merged 1 commit intofabfuel:developfrom
dzherb:add_reset

Conversation

@dzherb
Copy link
Copy Markdown
Contributor

@dzherb dzherb commented Mar 8, 2025

Fixed issue #64

The __call_succeeded method already did a reset, so i decided just to rename it.

I could do something like this instead:

def __call_succeeded(self):
    self.reset()

def reset(self):
    self._state = STATE_CLOSED
    self._last_failure = None
    self._failure_count = 0

But i thought there is no point, since __call_succeeded is only called in one place.

And, anyway, there is issue #60 that ideally should bring callbacks on state change. So there is no point to keep __call_succeeded.

@fabfuel fabfuel merged commit 6714117 into fabfuel:develop Mar 12, 2025
4 of 5 checks passed
@fabfuel
Copy link
Copy Markdown
Owner

fabfuel commented Mar 12, 2025

Thanks Dmitrii! 🙌

@fabfuel
Copy link
Copy Markdown
Owner

fabfuel commented Mar 12, 2025

I have released version 2.1.0 including your change
https://pypi.org/project/circuitbreaker/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants