Register functions with full names (including modules)#68
Open
yarjor wants to merge 1 commit intofabfuel:developfrom
Open
Register functions with full names (including modules)#68yarjor wants to merge 1 commit intofabfuel:developfrom
yarjor wants to merge 1 commit intofabfuel:developfrom
Conversation
Owner
|
Thanks for the PR @yarjor! That's certainly a good, pragmatic change, but I would prefer to have the deduplication happening once, on registration of a new Circuitbreaker instead of every time on read. What do you think about keeping Best |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partly fix #56 , review issue for reasoning behind the behavior change.
New behavior when decorating 2 functions from different modules with unnamed circuitbreakers will be: