Skip to content

Version check added as Calculator attribute#225

Merged
haneug merged 6 commits intofaccts:mainfrom
crjacinto:work
Apr 7, 2026
Merged

Version check added as Calculator attribute#225
haneug merged 6 commits intofaccts:mainfrom
crjacinto:work

Conversation

@crjacinto
Copy link
Copy Markdown
Contributor

@crjacinto crjacinto commented Apr 1, 2026

Closes Issues

Closes #223
...

Description

  • Added a version check attribute to the Calculator class. When defined, it also overrides the version check of get_output.

Release Notes

Added

  • Add version check attribute to Calculator, which is parsed to get_output

@crjacinto crjacinto requested a review from a team as a code owner April 1, 2026 12:47
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 1, 2026

CLA assistant check
All committers have signed the CLA.

@haneug haneug requested a review from nakul680 April 1, 2026 13:24
Copy link
Copy Markdown
Contributor

@haneug haneug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I have some minor suggestions for improvement.

Comment thread src/opi/core.py Outdated
Comment thread src/opi/core.py Outdated
Comment thread src/opi/core.py
@haneug haneug removed the request for review from nakul680 April 1, 2026 13:52
@haneug haneug added the enhancement New feature or request label Apr 1, 2026
@haneug haneug added this to the 3.0.0 milestone Apr 1, 2026
Copy link
Copy Markdown
Contributor

@timmyte timmyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some minor inconsistencies in the documentation ;)

Comment thread src/opi/core.py Outdated
Comment thread src/opi/core.py
Comment thread src/opi/core.py Outdated
Copy link
Copy Markdown
Contributor

@timmyte timmyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good from my side.
The double backticks should be replaced with single ones.

@haneug haneug merged commit 240a1c0 into faccts:main Apr 7, 2026
6 checks passed
@haneug
Copy link
Copy Markdown
Contributor

haneug commented Apr 7, 2026

@crjacinto Thank you for contributing to OPI!

@crjacinto crjacinto deleted the work branch April 7, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make version_check an attribute of the Calculator and hand it to the Output

4 participants