Open
Conversation
haneug
force-pushed
the
fix.version_check
branch
from
f9f3d87 to
066c0d7
Compare
timmyte
requested changes
Apr 7, 2026
Contributor
timmyte
left a comment
timmyte
left a comment
There was a problem hiding this comment.
Great idea to fix this. I would how ever apply the fix slightly further down in the code on deeper level.
Co-authored-by: Tim Tetenberg <123412573+timmyte@users.noreply.github.com>
This reverts commit 2c1ef6e.
Contributor
Author
|
Thanks I added your suggestions and also changed |
timmyte
approved these changes
Apr 15, 2026
Contributor
timmyte
left a comment
timmyte
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to version check.