Replace #Hash.reject with #Hash.compact#253
Open
ChefAustin wants to merge 8 commits intofacebook:mainfrom
ChefAustin:master
Open
Replace #Hash.reject with #Hash.compact#253ChefAustin wants to merge 8 commits intofacebook:mainfrom ChefAustin:master
ChefAustin wants to merge 8 commits intofacebook:mainfrom
ChefAustin:master
Conversation
added 5 commits
November 17, 2020 11:34
Contributor
Author
|
I went ahead and fixed all the CI errors (or disabled Rubocop wherever I deemed that to be best course of action). Let me know if y'all find any of my lint changes... offensive. 😎 |
Contributor
Author
|
Bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will do one thing: Replace all instances of #Hash.reject { |_k, v | v.nil? } with #Hash.compact.
This has been shown (chef/chef#10601) to increase speed by a reasonable amount and is a bit more simple (IMHO).
Tested this locally with Chef Solo and -- with a sample size of 4x runs -- our run_list went from an average run time of 30s (using .reject) to 24s (using .compact).