Add supports mac_os_x to fb_helpers/metadata.rb#263
Open
ChefAustin wants to merge 1 commit intofacebook:mainfrom
ChefAustin:patch-1
Open
Add supports mac_os_x to fb_helpers/metadata.rb#263ChefAustin wants to merge 1 commit intofacebook:mainfrom ChefAustin:patch-1
supports mac_os_x to fb_helpers/metadata.rb#263ChefAustin wants to merge 1 commit intofacebook:mainfrom
ChefAustin:patch-1
Conversation
- Add `supports mac_os_x` to `fb_helpers/metadata.rb` - Alphabetize `supports` list
dafyddcrosby
approved these changes
Jan 10, 2024
Contributor
Author
|
FWIW, looks like the CLA check might not be working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supports mac_os_xtofb_helpers/metadata.rbsupportslistWhat type of PR is this?
cleanup
What this PR does / why we need it:
fb_helpersis quite clearly designed with macOS in mind so themetadata.rbfile should reflect support for that platform.Special notes for your reviewer:
👋
Does this PR introduce a user-facing change?:
Additional documentation e.g., Design Proposals, usage docs, etc.: