BLACKWOLF800BANW: platform_manager support#851
Closed
dzarista wants to merge 1 commit intofacebook:mainfrom
Closed
BLACKWOLF800BANW: platform_manager support#851dzarista wants to merge 1 commit intofacebook:mainfrom
dzarista wants to merge 1 commit intofacebook:mainfrom
Conversation
This was referenced Jan 27, 2026
dzarista
force-pushed
the
blackwolf800banw_platform_manager
branch
from
0da4acc to
8d86d3a
Compare
dzarista
force-pushed
the
blackwolf800banw_platform_manager
branch
from
8d86d3a to
9cfb775
Compare
|
@RomanChoporov-Meta has imported this pull request. If you are a Meta employee, you can view this in D91694570. |
Contributor
|
Hey @dzarista, |
Contributor
Author
@arajeev-ARISTA will make a PR for this shortly. Thanks. |
dzarista
added a commit
to dzarista/fboss
that referenced
this pull request
Jan 29, 2026
This is part of a series of PRs to add support for BLACKWOLF800BANW. This PR adds: - Platform type definition (fboss_common.thrift, PlatformMode.h, PlatformProductInfo.cpp) - Platform mapping (Blackwolf800banwPlatformMapping) - SAI platform integration (SaiBcmBlackwolf800banwPlatform) Other PRs in this series: facebook#876 - Q4D ASIC definitions (dependency) facebook#851 - platform_manager support facebook#852 - sensor_service configs facebook#853 - fan_service configs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dzarista
added a commit
to dzarista/fboss
that referenced
this pull request
Jan 29, 2026
This is part of a series of PRs to add support for BLACKWOLF800BANW. This PR adds: - Platform type definition (fboss_common.thrift, PlatformMode.h, PlatformProductInfo.cpp) - Platform mapping (Blackwolf800banwPlatformMapping) - SAI platform integration (SaiBcmBlackwolf800banwPlatform) Other PRs in this series: facebook#876 - Q4D ASIC definitions (dependency) facebook#851 - platform_manager support facebook#852 - sensor_service configs facebook#853 - fan_service configs
This was referenced Jan 30, 2026
meta-codesync bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` This is the seventh PR in a series of PRs to add initial support for BLACKWOLF800BANW. This PR adds the sensor_service config for BLACKWOLF800BANW, which includes all the sensor definitions and thresholds, and the ASIC temperatureConfigs list. PRs in this series, ordered by landing priority: 1. #883 2. #884 3. #885 4. #886 5. #887 6. #851 7. #852 8. #853 Landing Priority: This PR should be landed seventh. Pull Request resolved: #852 Test Plan: Build passes when stacked on top of PRs 1-6. Testing was also performed in an environment with all the PRs in this series combined, with the following results: All sw_tests pass platform_manager_hw_test pass: ``` [==========] Running 8 tests from 1 test suite. [----------] Global test environment set-up. [----------] 8 tests from PlatformManagerHwTest [ RUN ] PlatformManagerHwTest.ExploreAsDeployed [ OK ] PlatformManagerHwTest.ExploreAsDeployed (39566 ms) [ RUN ] PlatformManagerHwTest.ExploreAfterUninstallingKmods [ OK ] PlatformManagerHwTest.ExploreAfterUninstallingKmods (40526 ms) [ RUN ] PlatformManagerHwTest.ExploreAfterUnloadingKmods [ OK ] PlatformManagerHwTest.ExploreAfterUnloadingKmods (121147 ms) [ RUN ] PlatformManagerHwTest.PmExplorationStatusTransitions [ OK ] PlatformManagerHwTest.PmExplorationStatusTransitions (41180 ms) [ RUN ] PlatformManagerHwTest.Symlinks [ OK ] PlatformManagerHwTest.Symlinks (39518 ms) [ RUN ] PlatformManagerHwTest.XcvrCtrlFiles [ OK ] PlatformManagerHwTest.XcvrCtrlFiles (41287 ms) [ RUN ] PlatformManagerHwTest.XcvrIoFiles [ OK ] PlatformManagerHwTest.XcvrIoFiles (40944 ms) [ RUN ] PlatformManagerHwTest.XcvrLedFiles [ OK ] PlatformManagerHwTest.XcvrLedFiles (41487 ms) [----------] 8 tests from PlatformManagerHwTest (405660 ms total) [----------] Global test environment tear-down [==========] 8 tests from 1 test suite ran. (405660 ms total) [ PASSED ] 8 tests. ``` sensor_service_hw_test pass: ``` [==========] Running 6 tests from 1 test suite. [----------] Global test environment set-up. [----------] 6 tests from SensorServiceHwTest [ RUN ] SensorServiceHwTest.GetAllSensors [ OK ] SensorServiceHwTest.GetAllSensors (1055 ms) [ RUN ] SensorServiceHwTest.GetBogusSensor [ OK ] SensorServiceHwTest.GetBogusSensor (1048 ms) [ RUN ] SensorServiceHwTest.GetSomeSensors [ OK ] SensorServiceHwTest.GetSomeSensors (3315 ms) [ RUN ] SensorServiceHwTest.GetSomeSensorsViaThrift [ OK ] SensorServiceHwTest.GetSomeSensorsViaThrift (8472 ms) [ RUN ] SensorServiceHwTest.SensorFetchODSCheck [ OK ] SensorServiceHwTest.SensorFetchODSCheck (1054 ms) [ RUN ] SensorServiceHwTest.CheckAllSensors [ OK ] SensorServiceHwTest.CheckAllSensors (1046 ms) [----------] 6 tests from SensorServiceHwTest (15992 ms total) [----------] Global test environment tear-down [==========] 6 tests from 1 test suite ran. (15992 ms total) [ PASSED ] 6 tests. ``` fan_service_hw_test pass: ``` [==========] Running 5 tests from 1 test suite. [----------] Global test environment set-up. [----------] 5 tests from FanServiceHwTest [ RUN ] FanServiceHwTest.TransitionalPWM [ OK ] FanServiceHwTest.TransitionalPWM (5 ms) [ RUN ] FanServiceHwTest.FanControl [ OK ] FanServiceHwTest.FanControl (114722 ms) [ RUN ] FanServiceHwTest.FanStatusesThrift [ OK ] FanServiceHwTest.FanStatusesThrift (20145 ms) [ RUN ] FanServiceHwTest.ODSCounters [ OK ] FanServiceHwTest.ODSCounters (13722 ms) [ RUN ] FanServiceHwTest.LedWriteDidNotFail [ OK ] FanServiceHwTest.LedWriteDidNotFail (12367 ms) [----------] 5 tests from FanServiceHwTest (160963 ms total) [----------] Global test environment tear-down [==========] 5 tests from 1 test suite ran. (160963 ms total) [ PASSED ] 5 tests. ``` data_corral_service_hw_test pass: ``` [==========] Running 5 tests from 1 test suite. [----------] Global test environment set-up. [----------] 5 tests from DataCorralServiceHwTest [ RUN ] DataCorralServiceHwTest.FruLedProgrammingSysfsCheck [ OK ] DataCorralServiceHwTest.FruLedProgrammingSysfsCheck (9 ms) [ RUN ] DataCorralServiceHwTest.FruLEDProgrammingODSCheck [ OK ] DataCorralServiceHwTest.FruLEDProgrammingODSCheck (8 ms) [ RUN ] DataCorralServiceHwTest.getCachedFruid [ OK ] DataCorralServiceHwTest.getCachedFruid (14879 ms) [ RUN ] DataCorralServiceHwTest.getUncachedFruid [ OK ] DataCorralServiceHwTest.getUncachedFruid (13504 ms) [ RUN ] DataCorralServiceHwTest.testThrift [ OK ] DataCorralServiceHwTest.testThrift (13765 ms) [----------] 5 tests from DataCorralServiceHwTest (42168 ms total) [----------] Global test environment tear-down [==========] 5 tests from 1 test suite ran. (42168 ms total) [ PASSED ] 5 tests. ``` weutil_hw_test pass: ``` [==========] Running 4 tests from 1 test suite. [----------] Global test environment set-up. [----------] 4 tests from WeutilTest [ RUN ] WeutilTest.getWedgeInfo [ OK ] WeutilTest.getWedgeInfo (10544 ms) [ RUN ] WeutilTest.getEepromPaths [ OK ] WeutilTest.getEepromPaths (0 ms) [ RUN ] WeutilTest.ValidateAllEepromContents [ OK ] WeutilTest.ValidateAllEepromContents (21034 ms) [ RUN ] WeutilTest.getInfoJson [ OK ] WeutilTest.getInfoJson (42348 ms) [----------] 4 tests from WeutilTest (73928 ms total) [----------] Global test environment tear-down [==========] 4 tests from 1 test suite ran. (73928 ms total) [ PASSED ] 4 tests. ``` Reviewed By: joancaneus Differential Revision: D91694649 Pulled By: RomanChoporov-Meta fbshipit-source-id: db0e5870774638b20c4588c9b2ed23a689ae2805
|
@RomanChoporov-Meta merged this pull request in 7237c6c. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` This is the eighth PR in a series of PRs to add initial support for BLACKWOLF800BANW. This PR adds the fan_service config for BLACKWOLF800BANW. The config conservatively starts the fans at 70% minimum duty cycle, scaling up to 100% maximum. PRs in this series, ordered by landing priority: 1. #883 (THIS PR). 2. #884 3. #885 4. #886 5. #887 6. #851 7. #852 8. #853 Landing Priority: This PR should be landed eighth. Pull Request resolved: #853 Test Plan: Build passes when stacked on top of PRs 1-7. Testing was also performed in an environment with all the PRs in this series combined, with the following results: All sw_tests pass platform_manager_hw_test pass: ``` [==========] Running 8 tests from 1 test suite. [----------] Global test environment set-up. [----------] 8 tests from PlatformManagerHwTest [ RUN ] PlatformManagerHwTest.ExploreAsDeployed [ OK ] PlatformManagerHwTest.ExploreAsDeployed (39566 ms) [ RUN ] PlatformManagerHwTest.ExploreAfterUninstallingKmods [ OK ] PlatformManagerHwTest.ExploreAfterUninstallingKmods (40526 ms) [ RUN ] PlatformManagerHwTest.ExploreAfterUnloadingKmods [ OK ] PlatformManagerHwTest.ExploreAfterUnloadingKmods (121147 ms) [ RUN ] PlatformManagerHwTest.PmExplorationStatusTransitions [ OK ] PlatformManagerHwTest.PmExplorationStatusTransitions (41180 ms) [ RUN ] PlatformManagerHwTest.Symlinks [ OK ] PlatformManagerHwTest.Symlinks (39518 ms) [ RUN ] PlatformManagerHwTest.XcvrCtrlFiles [ OK ] PlatformManagerHwTest.XcvrCtrlFiles (41287 ms) [ RUN ] PlatformManagerHwTest.XcvrIoFiles [ OK ] PlatformManagerHwTest.XcvrIoFiles (40944 ms) [ RUN ] PlatformManagerHwTest.XcvrLedFiles [ OK ] PlatformManagerHwTest.XcvrLedFiles (41487 ms) [----------] 8 tests from PlatformManagerHwTest (405660 ms total) [----------] Global test environment tear-down [==========] 8 tests from 1 test suite ran. (405660 ms total) [ PASSED ] 8 tests. ``` sensor_service_hw_test pass: ``` [==========] Running 6 tests from 1 test suite. [----------] Global test environment set-up. [----------] 6 tests from SensorServiceHwTest [ RUN ] SensorServiceHwTest.GetAllSensors [ OK ] SensorServiceHwTest.GetAllSensors (1055 ms) [ RUN ] SensorServiceHwTest.GetBogusSensor [ OK ] SensorServiceHwTest.GetBogusSensor (1048 ms) [ RUN ] SensorServiceHwTest.GetSomeSensors [ OK ] SensorServiceHwTest.GetSomeSensors (3315 ms) [ RUN ] SensorServiceHwTest.GetSomeSensorsViaThrift [ OK ] SensorServiceHwTest.GetSomeSensorsViaThrift (8472 ms) [ RUN ] SensorServiceHwTest.SensorFetchODSCheck [ OK ] SensorServiceHwTest.SensorFetchODSCheck (1054 ms) [ RUN ] SensorServiceHwTest.CheckAllSensors [ OK ] SensorServiceHwTest.CheckAllSensors (1046 ms) [----------] 6 tests from SensorServiceHwTest (15992 ms total) [----------] Global test environment tear-down [==========] 6 tests from 1 test suite ran. (15992 ms total) [ PASSED ] 6 tests. ``` fan_service_hw_test pass: ``` [==========] Running 5 tests from 1 test suite. [----------] Global test environment set-up. [----------] 5 tests from FanServiceHwTest [ RUN ] FanServiceHwTest.TransitionalPWM [ OK ] FanServiceHwTest.TransitionalPWM (5 ms) [ RUN ] FanServiceHwTest.FanControl [ OK ] FanServiceHwTest.FanControl (114722 ms) [ RUN ] FanServiceHwTest.FanStatusesThrift [ OK ] FanServiceHwTest.FanStatusesThrift (20145 ms) [ RUN ] FanServiceHwTest.ODSCounters [ OK ] FanServiceHwTest.ODSCounters (13722 ms) [ RUN ] FanServiceHwTest.LedWriteDidNotFail [ OK ] FanServiceHwTest.LedWriteDidNotFail (12367 ms) [----------] 5 tests from FanServiceHwTest (160963 ms total) [----------] Global test environment tear-down [==========] 5 tests from 1 test suite ran. (160963 ms total) [ PASSED ] 5 tests. ``` data_corral_service_hw_test pass: ``` [==========] Running 5 tests from 1 test suite. [----------] Global test environment set-up. [----------] 5 tests from DataCorralServiceHwTest [ RUN ] DataCorralServiceHwTest.FruLedProgrammingSysfsCheck [ OK ] DataCorralServiceHwTest.FruLedProgrammingSysfsCheck (9 ms) [ RUN ] DataCorralServiceHwTest.FruLEDProgrammingODSCheck [ OK ] DataCorralServiceHwTest.FruLEDProgrammingODSCheck (8 ms) [ RUN ] DataCorralServiceHwTest.getCachedFruid [ OK ] DataCorralServiceHwTest.getCachedFruid (14879 ms) [ RUN ] DataCorralServiceHwTest.getUncachedFruid [ OK ] DataCorralServiceHwTest.getUncachedFruid (13504 ms) [ RUN ] DataCorralServiceHwTest.testThrift [ OK ] DataCorralServiceHwTest.testThrift (13765 ms) [----------] 5 tests from DataCorralServiceHwTest (42168 ms total) [----------] Global test environment tear-down [==========] 5 tests from 1 test suite ran. (42168 ms total) [ PASSED ] 5 tests. ``` weutil_hw_test pass: ``` [==========] Running 4 tests from 1 test suite. [----------] Global test environment set-up. [----------] 4 tests from WeutilTest [ RUN ] WeutilTest.getWedgeInfo [ OK ] WeutilTest.getWedgeInfo (10544 ms) [ RUN ] WeutilTest.getEepromPaths [ OK ] WeutilTest.getEepromPaths (0 ms) [ RUN ] WeutilTest.ValidateAllEepromContents [ OK ] WeutilTest.ValidateAllEepromContents (21034 ms) [ RUN ] WeutilTest.getInfoJson [ OK ] WeutilTest.getInfoJson (42348 ms) [----------] 4 tests from WeutilTest (73928 ms total) [----------] Global test environment tear-down [==========] 4 tests from 1 test suite ran. (73928 ms total) [ PASSED ] 4 tests. ``` Reviewed By: joancaneus Differential Revision: D91694761 Pulled By: RomanChoporov-Meta fbshipit-source-id: 6290d4a7212fffef29fef08493ae247cd4c8ddc6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This is the sixth PR in a series of PRs to add initial support for BLACKWOLF800BANW.
This PR adds platform_manager support for BLACKWOLF800BANW. This includes:
Additionally, the config assumes PR #774 is landed, where CHASSIS/SMB idprom share the same physical idprom but a different offset.
PRs in this series, ordered by landing priority:
Landing Priority: This PR should be landed sixth.
Test Plan
Build passes when stacked on top of PRs 1-5 and #774.
Testing was also performed in an environment with all the PRs in this series combined, with the following results:
All sw_tests pass
platform_manager_hw_test pass:
sensor_service_hw_test pass:
fan_service_hw_test pass:
data_corral_service_hw_test pass:
weutil_hw_test pass: