Skip to content

[LinkTest] Fix speed change (200G->400g) test issue #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rancho333-CLS wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −0
Open

[LinkTest] Fix speed change (200G->400g) test issue #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c60936
[LinkTest] Fix speed change (200G->400g) test issue
Rancho333-CLS Mar 2, 2026
56e8edb
[LinkTest] Add a comment before calling updateCablePorts() to explain…
Rancho333-CLS Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions fboss/agent/test/link_tests/AgentEnsembleLinkTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,19 @@ class AgentEnsembleLinkTest : public AgentEnsembleTest {

void printProductionFeatures() const;

void updateCablePorts() {
cabledPorts_.clear();
auto swConfig = getSw()->getConfig();

for (const auto& port : *swConfig.ports()) {
if (!(*port.expectedLLDPValues()).empty() ||
!(*port.expectedNeighborReachability()).empty()) {
auto portID = *port.logicalID();
cabledPorts_.emplace_back(portID);
}
}
}

private:
void initializeCabledPorts();
void logLinkDbgMessage(std::vector<PortID>& portIDs) const override;
Expand Down
3 changes: 3 additions & 0 deletions fboss/agent/test/link_tests/AgentEnsembleSpeedChangeTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ class AgentEnsembleSpeedChangeTest : public AgentEnsembleLinkTest {
// updated
applyNewConfig(newConfig);

// Speed change may alter the number of logical ports,
// so we need to refresh the cabledPorts_.
updateCablePorts();
Copy link
Contributor

@harshitgulati18 harshitgulati18 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave a comment above this line that we need to update cabled ports since the previous speed change may add or remove ports

Copy link
Contributor Author

@Rancho333-CLS Rancho333-CLS Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

EXPECT_NO_THROW(waitForAllCabledPorts(true, 60, 5s););
createL3DataplaneFlood();
};
Expand Down
Loading