Remove usage of std::aligned_storage. #2527
Open
+29
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r-barnes Thoughts on how to get traction on this one? |
Contributor
|
@hansenyy - I'd defer to @yfeldblum on this one. If you an internal mass migration should happen, I can help with that, but Yedidya is a much better person to review this sort of change. |
Contributor
|
@hansenyy - if you don't get a reply from @yfeldblum in a week or so, could you ping me again? |
Author
|
@Orvid, thanks for importing this PR. I see that Builds and Tests are failing. Is there any way I can help resolve the failures even though I am not a Facebook employee? |
|
@r-barnes Could you assist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::aligned_storage and related types were deprecated in C++23. (See P1413R3 and #2321.) This PR removes usages of these types and replaces them with a simple equivalent implementation.