OSS buck build - demo with pins (do not land) #2542
Draft
+1,544
−817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
ben--
force-pushed
the
oss-buck-demo
branch
28 times, most recently
from
0a837cb to
bf7ecf4
Compare
sed -i "" -e '/PYTHON_EXTENSIONS/,$d' folly/CMakeLists.txt jj file show -r 7c61d2e- folly/CMakeLists.txt | sed -ne '/PYTHON_EXTENSIONS/,$p' >> folly/CMakeLists.txt
Use Promise/Future to control completion instead of futures::sleep, eliminating wall-clock timing dependencies that cause flaky failures on loaded CI systems.
Remove timing assertions (T_CHECK_TIMEOUT) that cause flakiness on Windows due to coarse timer resolution (~15.6ms). The test now verifies only the cancellation logic: which callbacks fired and which were cancelled. Timeout values increased to 50/100/200ms to be well above Windows timer resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT LAND THIS DIFF (see #2541)
Demo showing a working OSS buck build. Includes diffs that pin folly to the necessary changes to buck2-shims-meta, buck2, and buck2-preludee.