fix intermittent failure in HeapVectorTypes.SimpleSetTest #2554
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix intermittent failure in HeapVectorTypes.SimpleSetTest. When 32 isn’t present and all elements are <32, lower_bound(32) legitimately returns end(). The test immediately did if (*it == 32), which dereferences an end iterator, causing UB. Added a guard it == s2.end() before dereferencing. There was also flakiness if 32 is present and if s2.lower_bound(32); returned a lower value than 32 as then 32 not erased. Fixed by explicity erasing 32 before insert Differential Revision: D88592733
ahornby
added a commit
to ahornby/folly
that referenced
this pull request
Jan 12, 2026
) Summary: Fix intermittent failure in HeapVectorTypes.SimpleSetTest. When 32 isn’t present and all elements are <32, lower_bound(32) legitimately returns end(). The test immediately did if (*it == 32), which dereferences an end iterator, causing UB. Added a guard it == s2.end() before dereferencing. There was also flakiness if 32 is present and if s2.lower_bound(32); returned a lower value than 32 as then 32 not erased. Fixed by explicity erasing 32 before insert Differential Revision: D88592733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix intermittent failure in HeapVectorTypes.SimpleSetTest. When 32 isn’t present and all elements are <32, lower_bound(32) legitimately returns end(). The test immediately did if (*it == 32), which dereferences an end iterator, causing UB.
Added a guard it == s2.end() before dereferencing.
There was also flakiness if 32 is present and if s2.lower_bound(32); returned a lower value than 32 as then 32 not erased. Fixed by explicity erasing 32 before insert
Differential Revision: D88592733