Skip to content

Add draggable block support to list items #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lequavis wants to merge 1 commit into
base: main
Choose a base branch
from
+46 −39
Open

Add draggable block support to list items #7640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 46 additions & 39 deletions packages/lexical-react/src/LexicalDraggableBlockPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ function getCurrentIndex(keysLength: number): number {
return Math.floor(keysLength / 2);
}

function getTopLevelNodeKeys(editor: LexicalEditor): string[] {
return editor.getEditorState().read(() => $getRoot().getChildrenKeys());
}

function getCollapsedMargins(elem: HTMLElement): {
marginTop: number;
marginBottom: number;
Expand Down Expand Up @@ -97,8 +93,12 @@ function getBlockElement(
event: MouseEvent,
useEdgeAsDefault = false,
): HTMLElement | null {
const anchorElementRect = anchorElem.getBoundingClientRect();
const topLevelNodeKeys = getTopLevelNodeKeys(editor);
const anchorBounds = Rectangle.fromDOM(anchorElem);
const point = new Point(event.x, event.y);
Copy link
Collaborator

@ivailop7 ivailop7 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this account for the CSS zoom?

const zoom = calculateZoomLevel(elem);


const topLevelNodeKeys = editor
.getEditorState()
.read(() => $getRoot().getChildrenKeys());

let blockElem: HTMLElement | null = null;

Expand All @@ -109,64 +109,71 @@ function getBlockElement(
editor.getElementByKey(topLevelNodeKeys[topLevelNodeKeys.length - 1]),
];

const [firstNodeRect, lastNodeRect] = [
firstNode != null ? firstNode.getBoundingClientRect() : undefined,
lastNode != null ? lastNode.getBoundingClientRect() : undefined,
];

if (firstNodeRect && lastNodeRect) {
const firstNodeZoom = calculateZoomLevel(firstNode);
const lastNodeZoom = calculateZoomLevel(lastNode);
if (event.y / firstNodeZoom < firstNodeRect.top) {
if (firstNode && lastNode) {
const firstRect = firstNode.getBoundingClientRect();
const lastRect = lastNode.getBoundingClientRect();
if (event.y < firstRect.top) {
blockElem = firstNode;
} else if (event.y / lastNodeZoom > lastNodeRect.bottom) {
return;
} else if (event.y > lastRect.bottom) {
blockElem = lastNode;
}

if (blockElem) {
return;
}
}
}

const tryMatch = (targetElem: HTMLElement): boolean => {
const domRect = Rectangle.fromDOM(targetElem);
const {marginTop, marginBottom} = getCollapsedMargins(targetElem);
const expandedRect = domRect.generateNewRect({
bottom: domRect.bottom + marginBottom,
left: anchorBounds.left,
right: anchorBounds.right,
top: domRect.top - marginTop,
});

const {result} = expandedRect.contains(point);
return result;
};

let index = getCurrentIndex(topLevelNodeKeys.length);
let direction = Indeterminate;

while (index >= 0 && index < topLevelNodeKeys.length) {
const key = topLevelNodeKeys[index];
const elem = editor.getElementByKey(key);
if (elem === null) {
if (!elem) {
break;
}
const zoom = calculateZoomLevel(elem);
const point = new Point(event.x / zoom, event.y / zoom);
const domRect = Rectangle.fromDOM(elem);
const {marginTop, marginBottom} = getCollapsedMargins(elem);
const rect = domRect.generateNewRect({
bottom: domRect.bottom + marginBottom,
left: anchorElementRect.left,
right: anchorElementRect.right,
top: domRect.top - marginTop,
});

const {
result,
reason: {isOnTopSide, isOnBottomSide},
} = rect.contains(point);
let match: HTMLElement | null = null;

if (tryMatch(elem)) {
match = elem;

if (elem.tagName === 'UL' || elem.tagName === 'OL') {
for (const li of Array.from(elem.children) as HTMLElement[]) {
if (tryMatch(li)) {
match = li;
break;
}
}
}
}

if (result) {
blockElem = elem;
if (match) {
blockElem = match;
prevIndex = index;
break;
}

if (direction === Indeterminate) {
if (isOnTopSide) {
const domRect = elem.getBoundingClientRect();
if (event.y < domRect.top) {
direction = Upward;
} else if (isOnBottomSide) {
} else if (event.y > domRect.bottom) {
direction = Downward;
} else {
// stop search block element
direction = Infinity;
}
}
Expand Down
Loading