[lexical-clipboard] Fix: copy correct selection when editor in different window/document#7822
Merged
etrepum merged 1 commit intofacebook:mainfrom Sep 17, 2025
Merged
Conversation
james-atticus
requested review from
Fetz,
Sahejkm,
acywatson,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
ivailop7
approved these changes
Sep 17, 2025
Collaborator
|
#7790 probably fixes some more of these issues |
Collaborator
|
(or at least something like #7790, that someone is interested in actually finishing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the editor is mounted in a different window, for example when using react-new-window, then
copyToClipboardcopies the selection from the main window.Test plan
Tried to get a repro working with unit tests but couldn't get selection working with JSDOM.
Before
Copy using context menu gets the text from the parent window's selection:
Screen.Recording.2025-09-17.at.1.48.34.pm.mov
After
Screen.Recording.2025-09-17.at.1.56.39.pm.mov