Skip to content

[lexical][lexical-utils] Chore: Use workspace:* for monorepo versions and fix some cyclic dependencies#8106

Merged
etrepum merged 2 commits intofacebook:mainfrom
etrepum:cyclic-dependencies
Feb 2, 2026
Merged

[lexical][lexical-utils] Chore: Use workspace:* for monorepo versions and fix some cyclic dependencies#8106
etrepum merged 2 commits intofacebook:mainfrom
etrepum:cyclic-dependencies

Conversation

@etrepum
Copy link
Collaborator

@etrepum etrepum commented Feb 1, 2026

Description

This should fix the failures that are blocking the v0.40.0 release (#8104)

This fixes updateVersion to use workspace:* versions consistently. The normalization of these to exact versions should happen on publish by pnpm.

This moves a few very commonly used functions from @lexical/utils to lexical:

  • mergeRegister
  • addClassNames
  • removeClassNames
  • normalizeClassNames (internal)

It also removes some cyclic dependencies from @lexical/utils (it had depended on @lexical/table and @lexical/list which in turn depend on it, but this dependency is only used in tests which we don't need to declare in package.json)

Test plan

Unit tests should still pass, also after running the increment version workflow

… and fix some cyclic dependencies

mergeRegister, addClassNames, removeClassNames, normalizeClassNames to lexical
deprecated $filter as it was trivial and used only once
@vercel
Copy link

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Feb 2, 2026 1:50am
lexical-playground Ready Ready Preview, Comment Feb 2, 2026 1:50am

Request Review

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 1, 2026
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Feb 1, 2026
@ivailop7
Copy link
Collaborator

ivailop7 commented Feb 1, 2026

Approving to unblock, for when the failures get fixed.

@etrepum etrepum added this pull request to the merge queue Feb 2, 2026
Merged via the queue into facebook:main with commit 26ec991 Feb 2, 2026
60 of 64 checks passed
@etrepum etrepum mentioned this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants