[lexical-link] Bug Fix: Enable autolink matching when it unlinked#8165
[lexical-link] Bug Fix: Enable autolink matching when it unlinked#8165levensta wants to merge 4 commits intofacebook:mainfrom
Conversation
levensta
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
| ); | ||
| }); | ||
|
|
||
| test('Unlinked the autolink should not destruct if add non-spacing text in front or right after it', async ({ |
There was a problem hiding this comment.
Actually, if you insert non-space characters before or after the link, it also invalidates it if you consider the text as a whole (visually, it is a whole). I don't have a strong opinion on this case, so for now, I've fixed the current behavior with this test
Screen.Recording.2026-02-24.at.02.43.40.mov
The original PR #6306 was sent with the aim of resetting the link styles, but I don't know if users can have a link and text in a single string without a space between them, and whether this makes sense
There was a problem hiding this comment.
Other autolink implementations (e.g. google docs, github flavored markdown) will still autolink when the punctuation goes after the link, e.g. www.google.com! will autolink www.google.com. I don't have a super strong opinion about it, since you can always manually link text, but the GFM style autolink behavior is probably what more people are used to. Either way this PR's scope doesn't need to cover that sort of change.
levensta
force-pushed
the
check-valid-unlinked-autolink
branch
from
d0261f8 to
b0d32d4
Compare
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
I'm not sure this fixes the whole problem, e.g. if you have an unlinked AutoLinkNode and add a decorator like date or emoji it will split the AutoLinkNode instead of destroying any of them
If during transformation one of the child nodes is not a TextNode or is not simple, the link will be destroyed. I added a test with emoji |
|
The tests are failing for the second time in a specific job |
|
I'm not sure either without looking a lot more closely, which is hard for me since I don't have a windows computer to test with. unit tests would be fine, it's unclear if marking them as flaky would be a sufficient workaround. Really depends on what kind of timing issue it is. |
levensta
force-pushed
the
check-valid-unlinked-autolink
branch
from
c792aae to
475c316
Compare
|
I have no idea what's wrong with this test. I couldn't find any information about what exactly changes the legacy events job and what browser version is used, but I tried running the production build on Win 10 Chrome 86 through an online emulator and reproducing the scenario, and I get the expected result _Screen.Recording.2026-02-26.at.01.58.59.movI would suggest skipping this test specifically for legacy events + chromium + windows |
|
By the way, the video shows v0.40.dev, although I ran the build and preview on 0.41 🤷♂️ 
|
2 participants
Description
Previously, it was possible to enter invalid characters in the text of an unlinked AutoLinkNode, which made the link invalid. The fix activates parsing of valid links in AutoLinkNode if they are marked as unlinked
Test plan
Before
Screen.Recording.2026-02-24.at.02.14.48.mov
After
Screen.Recording.2026-02-24.at.02.16.35.mov