[Fix] : Linebreak insertion breaks format inheritance#8172
[Fix] : Linebreak insertion breaks format inheritance#8172Jynx2004 wants to merge 20 commits intofacebook:mainfrom
Conversation
…e $createParagraphNode
Removed unnecessary checks and code related to text node styles.
…exical into table_selection_issue
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
left a comment
There was a problem hiding this comment.
I will review this after it has new tests to show that the change has the desired behavior
Here only the passed argument is changed instead of sending static 0 value we have passed the actual format which will not need any new tests . It can be tested on existing tests. |
|
There needs to be a new test that shows that this change does something useful, and that future changes to lexical preserve that behavior. The existing test suite is not sufficient to show that your code works as expected. |
Will create some tests for testing this issue. |
Description
Instead of sending value 0 as a static value we take the current format from selection.format and pass it to the respective function responsible for format change.
As a result the format gets passed on between multiple linebreaks.
Closes #8160
Before
After